From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 307501FA2F for ; Tue, 24 Jan 2023 09:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1674553805; bh=Ev3fYbcVEsXgO7NNyCY08S8P7fAunOcREg2ThZ/AcOg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=2+7HZzNPtzFiB6cCbu4jkPpXfstzdoPlSbcnY7BwUj0bB8cPpZSiaajxIsuPTBox3 n1u9QWtNgrCIt9DZx0d4Cri+u3c4nGtjVRcRPb++X/Wea1kkyuT1VZCvkx4mLZbfFJ yk/ufzAclaDM+evbw3DsrK8zDfvDGYqEIXsBL/UQ= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 06/11] http: reuse STDIN if it's already /dev/null Date: Tue, 24 Jan 2023 09:49:35 +0000 Message-Id: <20230124094940.572017-7-e@80x24.org> In-Reply-To: <20230124094940.572017-1-e@80x24.org> References: <20230124094940.572017-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's typical for -netd/-httpd to have STDIN pointed to /dev/null, so try to use that instead of opening another file description. --- lib/PublicInbox/HTTP.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm index 0dba425d..ca162939 100644 --- a/lib/PublicInbox/HTTP.pm +++ b/lib/PublicInbox/HTTP.pm @@ -43,7 +43,13 @@ use Errno qw(EAGAIN); our $MAX_REQUEST_BUFFER = $ENV{GIT_HTTP_MAX_REQUEST_BUFFER} || (10 * 1024 * 1024); -open(my $null_io, '<', '/dev/null') or die "failed to open /dev/null: $!"; +open(my $null_io, '<', '/dev/null') or die "open /dev/null: $!"; +{ + my @n = stat($null_io) or die "stat(/dev/null): $!"; + my @i = stat(STDIN) or die "stat(STDIN): $!"; + $null_io = *STDIN{IO} if "@n[0, 1]" eq "@i[0, 1]"; +} + my $http_date; my $prev = 0; sub http_date () {