user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] searchview: fix uninitialized variable
@ 2023-01-17 18:25 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-01-17 18:25 UTC (permalink / raw)
  To: meta

Seems harmless, but noise in logs is not good.
---
 lib/PublicInbox/SearchView.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 8e33079f..07fef40c 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -34,7 +34,7 @@ sub sres_top_html {
 		return PublicInbox::WWW::need($ctx, 'Search');
 	my $q = PublicInbox::SearchQuery->new($ctx->{qp});
 	my $x = $q->{x};
-	my $o = $q->{o};
+	my $o = $q->{o} // 0;
 	my $asc;
 	if ($o < 0) {
 		$asc = 1;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-17 18:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 18:25 [PATCH] searchview: fix uninitialized variable Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).