user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 07/12] watch: simplify internal data structures
Date: Tue, 17 Jan 2023 07:19:06 +0000	[thread overview]
Message-ID: <20230117071911.1577890-8-e@80x24.org> (raw)
In-Reply-To: <20230117071911.1577890-1-e@80x24.org>

We can flatten arrays and avoid distinguishing between PID
types now that more of that logic and argument passing logic
is offloaded to awaitpid.
---
 lib/PublicInbox/Watch.pm | 49 ++++++++++++++++------------------------
 1 file changed, 19 insertions(+), 30 deletions(-)

diff --git a/lib/PublicInbox/Watch.pm b/lib/PublicInbox/Watch.pm
index 57985083..66b0c8b1 100644
--- a/lib/PublicInbox/Watch.pm
+++ b/lib/PublicInbox/Watch.pm
@@ -243,11 +243,7 @@ sub quit_done ($) {
 	return unless $self->{quit};
 
 	# don't have reliable wakeups, keep signalling
-	my $live = 0;
-	for (qw(idle_pids poll_pids)) {
-		my $pids = $self->{$_} or next;
-		$live += grep { kill('QUIT', $_) } keys %$pids;
-	}
+	my $live = grep { kill('QUIT', $_) } keys %{$self->{pids}};
 	add_timer(0.01, \&quit_done, $self) if $live;
 	$live == 0;
 }
@@ -379,8 +375,7 @@ sub watch_imap_idle_1 ($$$) {
 
 sub watch_atfork_child ($) {
 	my ($self) = @_;
-	delete $self->{idle_pids};
-	delete $self->{poll_pids};
+	delete $self->{pids};
 	delete $self->{opendirs};
 	PublicInbox::DS->Reset;
 	my $sig = delete $self->{sig};
@@ -392,27 +387,23 @@ sub watch_atfork_child ($) {
 sub watch_atfork_parent ($) { _done_for_now($_[0]) }
 
 sub imap_idle_requeue { # DS::add_timer callback
-	my ($self, $uri_intvl) = @_;
+	my ($self, $uri, $intvl) = @_;
 	return if $self->{quit};
-	push @{$self->{idle_todo}}, $uri_intvl;
+	push @{$self->{idle_todo}}, $uri, $intvl;
 	event_step($self);
 }
 
 sub imap_idle_reap { # awaitpid callback
-	my ($pid, $self) = @_;
-	my $uri_intvl = delete $self->{idle_pids}->{$pid} or
-		die "BUG: PID=$pid (unknown) reaped: \$?=$?\n";
-
-	my ($uri, $intvl) = @$uri_intvl;
+	my ($pid, $self, $uri, $intvl) = @_;
+	delete $self->{pids}->{$pid};
 	return if $self->{quit};
 	warn "W: PID=$pid on $uri died: \$?=$?\n" if $?;
-	add_timer(60, \&imap_idle_requeue, $self, $uri_intvl);
+	add_timer(60, \&imap_idle_requeue, $self, $uri, $intvl);
 }
 
-sub imap_idle_fork ($$) {
-	my ($self, $uri_intvl) = @_;
+sub imap_idle_fork {
+	my ($self, $uri, $intvl) = @_;
 	return if $self->{quit};
-	my ($uri, $intvl) = @$uri_intvl;
 	my $seed = rand(0xffffffff);
 	my $pid = fork // die "fork: $!";
 	if ($pid == 0) {
@@ -422,8 +413,8 @@ sub imap_idle_fork ($$) {
 		watch_imap_idle_1($self, $uri, $intvl);
 		_exit(0);
 	}
-	$self->{idle_pids}->{$pid} = $uri_intvl;
-	awaitpid($pid, \&imap_idle_reap, $self);
+	$self->{pids}->{$pid} = undef;
+	awaitpid($pid, \&imap_idle_reap, $self, $uri, $intvl);
 }
 
 sub event_step {
@@ -433,8 +424,8 @@ sub event_step {
 	if ($idle_todo && @$idle_todo) {
 		watch_atfork_parent($self);
 		eval {
-			while (my $uri_intvl = shift(@$idle_todo)) {
-				imap_idle_fork($self, $uri_intvl);
+			while (my ($uri, $intvl) = splice(@$idle_todo, 0, 2)) {
+				imap_idle_fork($self, $uri, $intvl);
 			}
 		};
 		die $@ if $@;
@@ -486,16 +477,14 @@ sub poll_fetch_fork { # DS::add_timer callback
 		}
 		_exit(0);
 	}
-	$self->{poll_pids}->{$pid} = [ $intvl, $uris ];
-	awaitpid($pid, \&poll_fetch_reap, $self);
+	$self->{pids}->{$pid} = undef;
+	awaitpid($pid, \&poll_fetch_reap, $self, $intvl, $uris);
 }
 
 sub poll_fetch_reap { # awaitpid callback
-	my ($pid, $self) = @_;
-	my $intvl_uris = delete $self->{poll_pids}->{$pid} or
-		die "BUG: PID=$pid (unknown) reaped: \$?=$?\n";
+	my ($pid, $self, $intvl, $uris) = @_;
+	delete $self->{pids}->{$pid};
 	return if $self->{quit};
-	my ($intvl, $uris) = @$intvl_uris;
 	if ($?) {
 		warn "W: PID=$pid died: \$?=$?\n", map { "$_\n" } @$uris;
 	}
@@ -506,14 +495,14 @@ sub poll_fetch_reap { # awaitpid callback
 sub watch_imap_init ($$) {
 	my ($self, $poll) = @_;
 	my $mics = PublicInbox::NetReader::imap_common_init($self);
-	my $idle = []; # [ [ uri1, intvl1 ], [uri2, intvl2] ]
+	my $idle = []; # [ uri1, intvl1, uri2, intvl2 ]
 	for my $uri (@{$self->{imap_order}}) {
 		my $sec = uri_section($uri);
 		my $mic = $mics->{$sec};
 		my $intvl = $self->{cfg_opt}->{$sec}->{pollInterval};
 		if ($mic->has_capability('IDLE') && !$intvl) {
 			$intvl = $self->{cfg_opt}->{$sec}->{idleInterval};
-			push @$idle, [ $uri, $intvl // () ];
+			push @$idle, $uri, $intvl;
 		} else {
 			push @{$poll->{$intvl || 120}}, $uri;
 		}

  parent reply	other threads:[~2023-01-17  7:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17  7:18 [PATCH 00/12] improve process reaping Eric Wong
2023-01-17  7:19 ` [PATCH 01/12] ipc: remove {-reap_async} field Eric Wong
2023-01-17  7:19 ` [PATCH 02/12] t/solver_git.t: fix test message Eric Wong
2023-01-17  7:19 ` [PATCH 03/12] qspawn: drop {psgi_env} deref Eric Wong
2023-01-17  7:19 ` [PATCH 04/12] ds: introduce awaitpid, switch ProcessPipe users Eric Wong
2023-01-18  2:10   ` [PATCH 13/12] qspawn: use ->DESTROY to force ->finalize Eric Wong
2023-01-17  7:19 ` [PATCH 05/12] git|gcf2: switch to awaitpid Eric Wong
2023-01-17  7:19 ` [PATCH 06/12] watch: " Eric Wong
2023-01-17  7:19 ` Eric Wong [this message]
2023-01-17  7:19 ` [PATCH 08/12] eofpipe: drop {arg} support for now Eric Wong
2023-01-17  7:19 ` [PATCH 09/12] watch: IMAP and NNTP polling can use the same interval Eric Wong
2023-01-17  7:19 ` [PATCH 10/12] ipc: drop unused $args from ->ipc_worker_stop Eric Wong
2023-01-17  7:19 ` [PATCH 11/12] ipc+lei: switch to awaitpid Eric Wong
2023-01-17  7:19 ` [PATCH 12/12] ds: drop dwaitpid, switch to waitpid(-1) Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117071911.1577890-8-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).