From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id D01AB1FA2C
	for <meta@public-inbox.org>; Tue, 17 Jan 2023 07:19:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1673939951;
	bh=aw2QFp+OHlCMGeOsqYw3AE0qMQB3Cm8Vnqu3ss6p1FA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=G7G5525P1u7A4TiXlVWfxKDYM1VO2elonNFFABjbf78ZatqgCcdoqb5/ECLUYoyot
	 4t2Bqp3+BjPEw4M1vRvnlHb0XEmqkad1Q0o4uK4ItjK2+9y/X2q6QXMvj1ZRQ2FBL7
	 ad5zLUC8qWKD7JWk17jWlKn3iaAGH73aozItEJiE=
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 03/12] qspawn: drop {psgi_env} deref
Date: Tue, 17 Jan 2023 07:19:02 +0000
Message-Id: <20230117071911.1577890-4-e@80x24.org>
In-Reply-To: <20230117071911.1577890-1-e@80x24.org>
References: <20230117071911.1577890-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <meta.public-inbox.org>

We don't use the assigned variable anywhere, and just access
PATH_INFO directly in the subsequent warning message.
---
 lib/PublicInbox/Qspawn.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 0044c1f6..779b703a 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -212,7 +212,6 @@ sub rd_hdr ($) {
 				$ret = [ 500, [], [ "Internal error\n" ] ];
 			} elsif (!defined($ret) && !$r) {
 				my $cmd = $self->{cmd} // [ '(?)' ];
-				my $env = $self->{psgi_env};
 				warn <<EOM;
 EOF parsing headers from @$cmd ($self->{psgi_env}->{REQUEST_URI})
 EOM