user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 1/2] clone: --dry-run unconditionally runs show-ref
Date: Fri, 30 Dec 2022 10:59:38 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

It's useful to show what's being updated, of course.
 lib/PublicInbox/ | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 5952ed52..bfbfd843 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -493,7 +493,6 @@ sub cmp_fp_do {
 	$self->{-show_ref} = $opt->{1};
 	$self->{lei}->qerr("# @$cmd");
-	return if $self->{dry_run};
 	$LIVE->{spawn($cmd, undef, $opt)} = [ \&fp_done, $self, $cmd,
 						$cb, @arg ];

  reply	other threads:[~2022-12-30 10:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30 10:59 [PATCH 0/2] clone fixups Eric Wong
2022-12-30 10:59 ` Eric Wong [this message]
2022-12-30 10:59 ` [PATCH 2/2] clone: fix --post-update-hook behavior Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).