From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 596C01F953 for ; Fri, 23 Dec 2022 12:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1671799868; bh=w0ezJRVdWfHWXiuBqpvu8tUWiK1XnOYjN4MRicmdwWk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=xJGtzpKUWnlVbdhQJZk0r/cYVgsqUGhP6+TuU1ErARX/aQY9m/kiS++R+qSWd+G+i Mr1m/LIoC/EXxSjgild9USCBln4nqzneN4PWHUYHgbQDIyEzuGkYcw8lO7pyLf1TLi tsIykTLFC2ERx9a3cQcXmDXqzqFHxzvzeeLml+X8= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/2] syscall: get rid of epoll_defined() sub Date: Fri, 23 Dec 2022 12:51:07 +0000 Message-Id: <20221223125108.963997-2-e@80x24.org> In-Reply-To: <20221223125108.963997-1-e@80x24.org> References: <20221223125108.963997-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: We can just check defined() on the `our' var itself and save the process several kilobytes of memory. --- lib/PublicInbox/DS.pm | 2 +- lib/PublicInbox/Syscall.pm | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index 26840662..a6c43b22 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -126,7 +126,7 @@ sub add_uniq_timer { # ($name, $secs, $coderef, @args) = @_; # caller sets return value to $Epoll sub _InitPoller () { - if (PublicInbox::Syscall::epoll_defined()) { + if (defined $PublicInbox::Syscall::SYS_epoll_create) { my $fd = epoll_create(); die "epoll_create: $!" if $fd < 0; open($ep_io, '+<&=', $fd) or return; diff --git a/lib/PublicInbox/Syscall.pm b/lib/PublicInbox/Syscall.pm index ee4c6107..bda9bbb0 100644 --- a/lib/PublicInbox/Syscall.pm +++ b/lib/PublicInbox/Syscall.pm @@ -285,8 +285,6 @@ if ($^O eq "linux") { # epoll functions ############################################################################ -sub epoll_defined { $SYS_epoll_create ? 1 : 0; } - sub epoll_create { syscall($SYS_epoll_create, $no_deprecated ? 0 : 100); }