user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/4] qspawn: shorten life of {hdr_buf} in generic code path
Date: Fri, 23 Dec 2022 11:05:14 +0000	[thread overview]
Message-ID: <20221223110515.19907-4-e@80x24.org> (raw)
In-Reply-To: <20221223110515.19907-1-e@80x24.org>

No point in keeping the old buffer around if we don't need to.
---
 lib/PublicInbox/Qspawn.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index ef9db43e..da7cd74f 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -247,9 +247,9 @@ sub psgi_return_init_cb {
 					delete($self->{hdr_buf}));
 	} else { # for synchronous PSGI servers
 		require PublicInbox::GetlineBody;
+		my $buf = delete $self->{hdr_buf};
 		$r->[2] = PublicInbox::GetlineBody->new($self->{rpipe},
-					\&event_step, $self,
-					${$self->{hdr_buf}}, $filter);
+					\&event_step, $self, $$buf, $filter);
 		$wcb->($r);
 	}
 }

  parent reply	other threads:[~2022-12-23 11:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 11:05 [PATCH 0/4] httpd/async fixes for coderepos Eric Wong
2022-12-23 11:05 ` [PATCH 1/4] httpd: avoid crash on cgit -> coderepo 404 fallback Eric Wong
2022-12-23 11:05 ` [PATCH 2/4] httpd/async: remove useless undef Eric Wong
2022-12-23 11:05 ` Eric Wong [this message]
2022-12-23 11:05 ` [PATCH 4/4] httpd/async + qspawn: rename {fh} fields Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221223110515.19907-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).