From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/4] httpd/async: remove useless undef
Date: Fri, 23 Dec 2022 11:05:13 +0000 [thread overview]
Message-ID: <20221223110515.19907-3-e@80x24.org> (raw)
In-Reply-To: <20221223110515.19907-1-e@80x24.org>
Assigning `undef' to a scalar doesn't free it's memory,
we need to call `undef($var)' in the caller. It's also
been pointless since we simplified ->async_pass in commit
b7fbffd1f8c12556 (httpd/async: get rid of ephemeral main_cb, 2019-12-25)
---
lib/PublicInbox/HTTPD/Async.pm | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm
index 9e592f47..75b3bd50 100644
--- a/lib/PublicInbox/HTTPD/Async.pm
+++ b/lib/PublicInbox/HTTPD/Async.pm
@@ -84,10 +84,6 @@ sub async_pass {
# *_wcb methods respond to ->write (and ->close), not ->print
$fh->write($$bref);
- # we're done with this, free this memory up ASAP since the
- # calls after this may use much memory:
- $$bref = undef;
-
$self->{http} = $http;
$self->{fh} = $fh;
}
next prev parent reply other threads:[~2022-12-23 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 11:05 [PATCH 0/4] httpd/async fixes for coderepos Eric Wong
2022-12-23 11:05 ` [PATCH 1/4] httpd: avoid crash on cgit -> coderepo 404 fallback Eric Wong
2022-12-23 11:05 ` Eric Wong [this message]
2022-12-23 11:05 ` [PATCH 3/4] qspawn: shorten life of {hdr_buf} in generic code path Eric Wong
2022-12-23 11:05 ` [PATCH 4/4] httpd/async + qspawn: rename {fh} fields Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221223110515.19907-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).