user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] search_query: fix warnings on empty "o=" query
@ 2022-12-14 22:24 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-12-14 22:24 UTC (permalink / raw)
  To: meta

This fixes the following warnings from bad URLs:

  Odd number of elements in anonymous hash at <>/PublicInbox/SearchQuery.pm line 22.
  Argument "l" isn't numeric in numeric lt (<) at <>/PublicInbox/SearchView.pm line 39.
---
 lib/PublicInbox/SearchQuery.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/SearchQuery.pm b/lib/PublicInbox/SearchQuery.pm
index a6b7d843..96246c53 100644
--- a/lib/PublicInbox/SearchQuery.pm
+++ b/lib/PublicInbox/SearchQuery.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
 # used by PublicInbox::SearchView and PublicInbox::WwwListing
@@ -16,10 +16,11 @@ sub new {
 	my $t = $qp->{t}; # collapse threads
 	my ($l) = (($qp->{l} || '') =~ /([0-9]+)/);
 	$l = $LIM if !$l || $l > $LIM;
+	my ($o) = (($qp->{o} || '0') =~ /(-?[0-9]+)/);
 	bless {
 		q => $qp->{'q'},
 		x => $qp->{x} || '',
-		o => (($qp->{o} || '0') =~ /(-?[0-9]+)/),
+		o => $o,
 		l => $l,
 		r => (defined $r && $r ne '0'),
 		t => (defined $t && $t ne '0'),

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-14 22:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 22:24 [PATCH] search_query: fix warnings on empty "o=" query Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).