From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] search_query: fix warnings on empty "o=" query
Date: Wed, 14 Dec 2022 22:24:08 +0000 [thread overview]
Message-ID: <20221214222408.560-1-e@80x24.org> (raw)
This fixes the following warnings from bad URLs:
Odd number of elements in anonymous hash at <>/PublicInbox/SearchQuery.pm line 22.
Argument "l" isn't numeric in numeric lt (<) at <>/PublicInbox/SearchView.pm line 39.
---
lib/PublicInbox/SearchQuery.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchQuery.pm b/lib/PublicInbox/SearchQuery.pm
index a6b7d843..96246c53 100644
--- a/lib/PublicInbox/SearchQuery.pm
+++ b/lib/PublicInbox/SearchQuery.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# used by PublicInbox::SearchView and PublicInbox::WwwListing
@@ -16,10 +16,11 @@ sub new {
my $t = $qp->{t}; # collapse threads
my ($l) = (($qp->{l} || '') =~ /([0-9]+)/);
$l = $LIM if !$l || $l > $LIM;
+ my ($o) = (($qp->{o} || '0') =~ /(-?[0-9]+)/);
bless {
q => $qp->{'q'},
x => $qp->{x} || '',
- o => (($qp->{o} || '0') =~ /(-?[0-9]+)/),
+ o => $o,
l => $l,
r => (defined $r && $r ne '0'),
t => (defined $t && $t ne '0'),
reply other threads:[~2022-12-14 22:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214222408.560-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).