From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9F7ED203B5 for ; Mon, 28 Nov 2022 05:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1669613566; bh=eck/kZZ+z5e+6sqCzrBGyXSwtQOlfT1rhisoWn3CLOo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=m8Y/fn0ob7cYG7dfViufACKA/FFZQg2D5Cuvi6BWCyA2SvxML9hNEjLLqCmcQnhPp AIxq8eQ7JX2sV2PBC4skQjY30/fUeosbO4NcPSK/H4t403DmerCZmsoPWgLzEvc5e3 GuPvai/YgJIRzb3Pcrv1XZLzmjE7UG9qLKw0OgJQ= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 66/95] lei_mirror: show child error error code Date: Mon, 28 Nov 2022 05:32:03 +0000 Message-Id: <20221128053232.291618-67-e@80x24.org> In-Reply-To: <20221128053232.291618-1-e@80x24.org> References: <20221128053232.291618-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Just passing the exit value of the child process isn't to our parent process isn't very useful when multiple commands are failing at once. --- lib/PublicInbox/LeiMirror.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index 4464b6b1..8b276336 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -602,7 +602,7 @@ sub reap_cmd { # async, called via SIGCHLD $? = 0; # don't let it influence normal exit if ($cerr) { kill('TERM', keys %$LIVE); - $self->{lei}->child_error($cerr, "@$cmd failed"); + $self->{lei}->child_error($cerr, "@$cmd failed (\$?=$cerr)"); } }