From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9152A203B0 for ; Mon, 28 Nov 2022 05:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1669613565; bh=8Pyrwz8jAc40XeEdgCz36g5YhA1eymHpXtoVcWbaSQc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ZmBC0Nu/AznpveQc7rVfEQbIz+Voo9nSsJJIamQ0t/xWnb7zjg1XG0JePkaXlaNj2 rDH4056Doohqt9koRZhPT3sUn+gSxBK1ROx1hylnaSY9ZdCEkGjrEK+2xmArk5H4uH vBlY3ihgactSVUn38VneQu0jzPCKpfsJHwg4fYkk= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 61/95] clone: require `--objstore=' for default location Date: Mon, 28 Nov 2022 05:31:58 +0000 Message-Id: <20221128053232.291618-62-e@80x24.org> In-Reply-To: <20221128053232.291618-1-e@80x24.org> References: <20221128053232.291618-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Allowing just `--objstore' without `=' was confusing, since it could eat one of the required parameters (URL or DESTINATION). --- Documentation/public-inbox-clone.pod | 8 ++++---- script/public-inbox-clone | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/public-inbox-clone.pod b/Documentation/public-inbox-clone.pod index cee9f76e..257967d9 100644 --- a/Documentation/public-inbox-clone.pod +++ b/Documentation/public-inbox-clone.pod @@ -84,15 +84,15 @@ Force a remote public-inbox version (must be C<1> or C<2>). This is auto-detected by default, and this option exists mainly for testing. -=item --objstore[=DIR] +=item --objstore=DIR Enables space savings when the remote C includes C entries as generated by grokmirror 2.x. If C is not an absolute path, it is relative to the -C directory. If only C<--objstore> is specified -without C, then C (C<$DESTINATION/objstore>) -is the implied value of C. +C directory. If only C<--objstore=> is specified +where C is an empty string (C<"">), then C +(C<$DESTINATION/objstore>) is the implied value of C. =item -n diff --git a/script/public-inbox-clone b/script/public-inbox-clone index 26f42e74..e38d7b0d 100755 --- a/script/public-inbox-clone +++ b/script/public-inbox-clone @@ -13,7 +13,7 @@ usage: public-inbox-clone INBOX_URL [DESTINATION] options: --epoch=RANGE range of v2 epochs to clone (e.g `2..5', `~0', `~1..') - --objstore [DIR] share storage for coderepos + --objstore=DIR share storage for coderepos --torsocks VAL whether or not to wrap git and curl commands with torsocks (default: `auto') Must be one of: `auto', `no' or `yes' @@ -23,7 +23,7 @@ options: -C DIR chdir to specified directory EOF GetOptions($opt, qw(help|h quiet|q verbose|v+ C=s@ c=s@ include|I=s@ exclude=s@ - inbox-config=s inbox-version=i objstore:s + inbox-config=s inbox-version=i objstore=s dry-run|n jobs|j=i no-torsocks torsocks=s epoch=s)) or die $help; if ($opt->{help}) { print $help; exit }; require PublicInbox::Admin; # loads Config