From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E757E203AD for ; Mon, 28 Nov 2022 05:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1669613565; bh=J5PGW5AqY/5fZzCkX86IKFL/cjzXLoCgwW3+UkTEFyo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=fa7sqLxtkHzlxcK+0l+bV5U/YUDRn/yBM46no4R4kqSv4nCB82XAkdRzwANX1rdh1 I5PUEk2pxFSoDcFiEMRU1APKk9O/ka5ovl8uzS7IDOJx3MaC4iR9B6ZYn4v9Qpg4T0 dGMFKrOS37a23ypZe9chA+fkFobSVf6VNNIxB11A= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 58/95] clone: move --dry-run handling to lei_mirror Date: Mon, 28 Nov 2022 05:31:55 +0000 Message-Id: <20221128053232.291618-59-e@80x24.org> In-Reply-To: <20221128053232.291618-1-e@80x24.org> References: <20221128053232.291618-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: lei will probably support dry-run in more places, too. --- lib/PublicInbox/LeiMirror.pm | 1 + script/public-inbox-clone | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index 8b55a7da..2da4f881 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -938,6 +938,7 @@ sub start_clone_url { sub do_mirror { # via wq_io_do or public-inbox-clone my ($self) = @_; my $lei = $self->{lei}; + $self->{dry_run} = 1 if $lei->{opt}->{'dry-run'}; umask($lei->{client_umask}) if defined $lei->{client_umask}; eval { my $ic = $lei->{opt}->{'inbox-config'} //= 'always'; diff --git a/script/public-inbox-clone b/script/public-inbox-clone index 59f01b54..44626936 100755 --- a/script/public-inbox-clone +++ b/script/public-inbox-clone @@ -59,7 +59,6 @@ my $mrr = bless { }, 'PublicInbox::LeiMirror'; $? = 0; -$mrr->{dry_run} = 1 if $lei->{opt}->{'dry-run'}; $mrr->do_mirror; $mrr->can('_wq_done_wait')->([$mrr, $lei], $$); exit(($lei->{child_error} // 0) >> 8);