From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] filter/rubylang: adjust filter for new list software
Date: Sat, 26 Nov 2022 07:24:02 +0000 [thread overview]
Message-ID: <20221126072402.23807-1-e@80x24.org> (raw)
The host serving ruby-core and ruby-dev no longer set
X-Mail-Count, but the serial number remains active in
the Subject.
---
lib/PublicInbox/Filter/RubyLang.pm | 29 +++++++++++++++++------------
t/filter_rubylang.t | 16 ++++++++++++----
2 files changed, 29 insertions(+), 16 deletions(-)
diff --git a/lib/PublicInbox/Filter/RubyLang.pm b/lib/PublicInbox/Filter/RubyLang.pm
index 09aa6aa8..57ebbe78 100644
--- a/lib/PublicInbox/Filter/RubyLang.pm
+++ b/lib/PublicInbox/Filter/RubyLang.pm
@@ -1,11 +1,10 @@
-# Copyright (C) 2017-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# Filter for lists.ruby-lang.org trailers
package PublicInbox::Filter::RubyLang;
-use base qw(PublicInbox::Filter::Base);
-use strict;
-use warnings;
+use v5.10.1;
+use parent qw(PublicInbox::Filter::Base);
use PublicInbox::MID qw(mids);
my $l1 = qr/Unsubscribe:\s
@@ -56,16 +55,22 @@ sub scrub {
my $hdr = $mime->header_obj;
my $mids = mids($hdr);
return $self->REJECT('Message-ID missing') unless (@$mids);
- my @v = $hdr->header_raw('X-Mail-Count');
my $n;
- foreach (@v) {
- /\A\s*([0-9]+)\s*\z/ or next;
- $n = $1;
- last;
- }
- unless (defined $n) {
- return $self->REJECT('X-Mail-Count not numeric');
+ my @v = $hdr->header_raw('X-Mail-Count'); # old host only
+ if (@v) {
+ for (@v) {
+ /\A\s*([0-9]+)\s*\z/ or next;
+ $n = $1;
+ last;
+ }
+ } else { # new host: nue.mailmanlists.eu
+ for ($hdr->header_str('Subject')) {
+ /\A\[ruby-[^:]+:([0-9]+)\]/ or next;
+ $n = $1;
+ last;
+ }
}
+ $n // return $self->REJECT('could not get count not numeric');
foreach my $mid (@$mids) {
my $r = $altid->mm_alt->mid_set($n, $mid);
next if $r == 0;
diff --git a/t/filter_rubylang.t b/t/filter_rubylang.t
index 4e9695e1..490a2154 100644
--- a/t/filter_rubylang.t
+++ b/t/filter_rubylang.t
@@ -1,8 +1,7 @@
-# Copyright (C) 2017-2021 all contributors <meta@public-inbox.org>
+#!perl -w
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
-use strict;
-use warnings;
-use Test::More;
+use v5.12;
use PublicInbox::Eml;
use PublicInbox::TestCommon;
use_ok 'PublicInbox::Filter::RubyLang';
@@ -56,6 +55,15 @@ EOF
$mime = PublicInbox::Eml->new($msg);
$ret = $f->delivery($mime);
is($ret, 100, "delivery rejected without X-Mail-Count");
+
+ $mime = PublicInbox::Eml->new(<<'EOM');
+Message-ID: <new@host>
+Subject: [ruby-core:13] times
+
+EOM
+ $ret = $f->delivery($mime);
+ is($ret, $mime, "delivery successful");
+ is($mm->num_for('new@host'), 13, 'MM entry created based on Subject');
}
done_testing();
reply other threads:[~2022-11-26 7:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221126072402.23807-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).