user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] lei_curl: use http.proxy config from git if available
Date: Wed, 23 Nov 2022 04:09:58 +0000	[thread overview]
Message-ID: <20221123040958.114960-4-e@80x24.org> (raw)
In-Reply-To: <20221123040958.114960-1-e@80x24.org>

Since HTTP(S) URLs hit by lei or public-inbox-{clone,fetch} are
expected to be git endpoints anyways, fall back to using
http.proxy from git configs to save the user from having to
maintain the same configuration for different things.
---
 lib/PublicInbox/Config.pm  | 16 +++++++++++-----
 lib/PublicInbox/LeiCurl.pm |  2 +-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 6a51226e..5620bd0e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -533,7 +533,7 @@ sub _fill_ei ($$) {
 }
 
 sub urlmatch {
-	my ($self, $key, $url) = @_;
+	my ($self, $key, $url, $try_git) = @_;
 	state $urlmatch_broken; # requires git 1.8.5
 	return if $urlmatch_broken;
 	my $file = $self->{'-f'} // default_file();
@@ -542,13 +542,19 @@ sub urlmatch {
 	my $fh = popen_rd($cmd);
 	local $/ = "\0";
 	my $val = <$fh>;
-	if (close($fh)) {
-		chomp($val);
-	} else {
-		$urlmatch_broken = 1 if (($? >> 8) != 1);
+	if (!close($fh)) {
 		undef $val;
+		if (($? >> 8) != 1) {
+			$urlmatch_broken = 1;
+		} elsif ($try_git) { # n.b. this takes cwd into account
+			$cmd = [qw(git config -z --get-urlmatch), $key, $url];
+			$fh = popen_rd($cmd);
+			$val = <$fh>;
+			close($fh) or undef($val);
+		}
 	}
 	$? = 0; # don't influence lei exit status
+	chomp $val if defined $val;
 	$val;
 }
 
diff --git a/lib/PublicInbox/LeiCurl.pm b/lib/PublicInbox/LeiCurl.pm
index f5e95956..48c66ee9 100644
--- a/lib/PublicInbox/LeiCurl.pm
+++ b/lib/PublicInbox/LeiCurl.pm
@@ -76,7 +76,7 @@ sub for_uri {
 	my $pfx = torsocks($self, $lei, $uri) or return; # error
 	if ($uri->scheme =~ /\Ahttps?\z/i) {
 		my $cfg = $lei->_lei_cfg;
-		my $p = $cfg ? $cfg->urlmatch('http.Proxy', $$uri) : undef;
+		my $p = $cfg ? $cfg->urlmatch('http.Proxy', $$uri, 1) : undef;
 		push(@opt, '--proxy', $p) if defined($p);
 	}
 	bless [ @$pfx, @$self, @opt, $uri->as_string ], ref($self);

      parent reply	other threads:[~2022-11-23  4:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  4:09 [PATCH 0/3] proxy-related things Eric Wong
2022-11-23  4:09 ` [PATCH 1/3] lei_curl: set --proxy for curl(1) properly Eric Wong
2022-11-23  4:09 ` [PATCH 2/3] config: urlmatch $? does not influence our exits Eric Wong
2022-11-23  4:09 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123040958.114960-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).