user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] config: urlmatch $? does not influence our exits
Date: Wed, 23 Nov 2022 04:09:57 +0000	[thread overview]
Message-ID: <20221123040958.114960-3-e@80x24.org> (raw)
In-Reply-To: <20221123040958.114960-1-e@80x24.org>

We don't want to leak $? from `git config' failures into
lei nor public-inbox-* processes.
---
 lib/PublicInbox/Config.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index c27928de..6a51226e 100644
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -544,11 +544,12 @@ sub urlmatch {
 	my $val = <$fh>;
 	if (close($fh)) {
 		chomp($val);
-		$val;
 	} else {
 		$urlmatch_broken = 1 if (($? >> 8) != 1);
-		undef;
+		undef $val;
 	}
+	$? = 0; # don't influence lei exit status
+	$val;
 }
 
 sub json {

  parent reply	other threads:[~2022-11-23  4:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  4:09 [PATCH 0/3] proxy-related things Eric Wong
2022-11-23  4:09 ` [PATCH 1/3] lei_curl: set --proxy for curl(1) properly Eric Wong
2022-11-23  4:09 ` Eric Wong [this message]
2022-11-23  4:09 ` [PATCH 3/3] lei_curl: use http.proxy config from git if available Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123040958.114960-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).