From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] lei_curl: set --proxy for curl(1) properly
Date: Wed, 23 Nov 2022 04:09:56 +0000 [thread overview]
Message-ID: <20221123040958.114960-2-e@80x24.org> (raw)
In-Reply-To: <20221123040958.114960-1-e@80x24.org>
curl(1) doesn't accept `--proxy=' with the `=', apparently :x
---
lib/PublicInbox/LeiCurl.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/LeiCurl.pm b/lib/PublicInbox/LeiCurl.pm
index 4e602a48..f5e95956 100644
--- a/lib/PublicInbox/LeiCurl.pm
+++ b/lib/PublicInbox/LeiCurl.pm
@@ -7,8 +7,7 @@
# n.b. curl may support a daemon/client model like lei someday:
# https://github.com/curl/curl/wiki/curl-tool-master-client
package PublicInbox::LeiCurl;
-use strict;
-use v5.10.1;
+use v5.12;
use PublicInbox::Spawn qw(which);
use PublicInbox::Config;
@@ -78,7 +77,7 @@ sub for_uri {
if ($uri->scheme =~ /\Ahttps?\z/i) {
my $cfg = $lei->_lei_cfg;
my $p = $cfg ? $cfg->urlmatch('http.Proxy', $$uri) : undef;
- push(@opt, "--proxy=$p") if defined($p);
+ push(@opt, '--proxy', $p) if defined($p);
}
bless [ @$pfx, @$self, @opt, $uri->as_string ], ref($self);
}
next prev parent reply other threads:[~2022-11-23 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 4:09 [PATCH 0/3] proxy-related things Eric Wong
2022-11-23 4:09 ` Eric Wong [this message]
2022-11-23 4:09 ` [PATCH 2/3] config: urlmatch $? does not influence our exits Eric Wong
2022-11-23 4:09 ` [PATCH 3/3] lei_curl: use http.proxy config from git if available Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123040958.114960-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).