user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] git_async_cat: automatically cleanup temporary gits
@ 2022-10-01  0:07 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-10-01  0:07 UTC (permalink / raw)
  To: meta

This prevents temporary directories and git processes from
lingering around after WWW solver requests.
---
 lib/PublicInbox/GitAsyncCat.pm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index b32c2fd3..2d601542 100644
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -45,6 +45,12 @@ sub event_step {
 	}
 }
 
+sub git_tmp_cleanup {
+	my ($git) = @_;
+	$git->cleanup(1) and
+		PublicInbox::DS::add_timer(3, \&git_tmp_cleanup, $git);
+}
+
 sub ibx_async_cat ($$$$) {
 	my ($ibx, $oid, $cb, $arg) = @_;
 	my $git = $ibx->{git} // $ibx->git;
@@ -63,6 +69,8 @@ sub ibx_async_cat ($$$$) {
 		$git->{async_cat} //= do {
 			my $self = bless { git => $git }, __PACKAGE__;
 			$git->{in}->blocking(0);
+			$git->{-tmp} and PublicInbox::DS::add_uniq_timer(
+						3, \&git_tmp_cleanup, $git);
 			$self->SUPER::new($git->{in}, EPOLLIN|EPOLLET);
 			\undef; # this is a true ref()
 		};

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-01  0:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-01  0:07 [PATCH] git_async_cat: automatically cleanup temporary gits Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).