user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/4] t/lei-up: improve diagnostics for this test
Date: Fri, 30 Sep 2022 09:21:38 +0000	[thread overview]
Message-ID: <20220930092140.3894047-3-e@80x24.org> (raw)
In-Reply-To: <20220930092140.3894047-1-e@80x24.org>

I'm getting occasional failures for this test on CentOS 7.x (but
not on FreeBSD nor Debian 10/11).  I'm not why, yet, so just
improve diagnostics for now.
---
 t/lei-up.t | 43 +++++++++++++++++++++++++++----------------
 1 file changed, 27 insertions(+), 16 deletions(-)

diff --git a/t/lei-up.t b/t/lei-up.t
index 022ebc05..baed6507 100644
--- a/t/lei-up.t
+++ b/t/lei-up.t
@@ -5,39 +5,50 @@ use strict; use v5.10.1; use PublicInbox::TestCommon;
 use IO::Uncompress::Gunzip qw(gunzip $GunzipError);
 test_lei(sub {
 	my ($ro_home, $cfg_path) = setup_public_inboxes;
-	my $s = eml_load('t/plack-qp.eml')->as_string;
+	my $home = $ENV{HOME};
+	my $qp = eml_load('t/plack-qp.eml');
+	my $s = $qp->as_string;
 	lei_ok [qw(import -q -F eml -)], undef, { 0 => \$s, %$lei_opt };
-	lei_ok qw(q z:0.. -f mboxcl2 -o), "$ENV{HOME}/a.mbox.gz";
-	lei_ok qw(q z:0.. -f mboxcl2 -o), "$ENV{HOME}/b.mbox.gz";
-	lei_ok qw(q z:0.. -f mboxcl2 -o), "$ENV{HOME}/a";
-	lei_ok qw(q z:0.. -f mboxcl2 -o), "$ENV{HOME}/b";
+	lei_ok qw(q z:0.. -f mboxcl2 -o), "$home/a.mbox.gz";
+	lei_ok qw(q z:0.. -f mboxcl2 -o), "$home/b.mbox.gz";
+	lei_ok qw(q z:0.. -f mboxcl2 -o), "$home/a";
+	lei_ok qw(q z:0.. -f mboxcl2 -o), "$home/b";
+	my $uc;
+	for my $x (qw(a b)) {
+		gunzip("$home/$x.mbox.gz" => \$uc, MultiStream => 1) or
+				xbail "gunzip $GunzipError";
+		ok(index($uc, $qp->body_raw) >= 0,
+			"original mail in $x.mbox.gz");
+		open my $fh, '<', "$home/$x" or xbail $!;
+		$uc = do { local $/; <$fh> } // xbail $!;
+		ok(index($uc, $qp->body_raw) >= 0,
+			"original mail in uncompressed $x");
+	}
 	lei_ok qw(ls-search);
 	$s = eml_load('t/utf8.eml')->as_string;
 	lei_ok [qw(import -q -F eml -)], undef, { 0 => \$s, %$lei_opt };
 	lei_ok qw(up --all=local);
-	open my $fh, '<', "$ENV{HOME}/a.mbox.gz" or xbail "open: $!";
-	my $gz = do { local $/; <$fh> };
-	my $uc;
-	gunzip(\$gz => \$uc, MultiStream => 1) or xbail "gunzip $GunzipError";
-	open $fh, '<', "$ENV{HOME}/a" or xbail "open: $!";
 
+	gunzip("$home/a.mbox.gz" => \$uc, MultiStream => 1) or
+		 xbail "gunzip $GunzipError";
+
+	open my $fh, '<', "$home/a" or xbail "open: $!";
 	my $exp = do { local $/; <$fh> };
 	is($uc, $exp, 'compressed and uncompressed match (a.gz)');
 	like($exp, qr/testmessage\@example.com/, '2nd message added');
-	open $fh, '<', "$ENV{HOME}/b.mbox.gz" or xbail "open: $!";
 
-	$gz = do { local $/; <$fh> };
 	undef $uc;
-	gunzip(\$gz => \$uc, MultiStream => 1) or xbail "gunzip $GunzipError";
+	gunzip("$home/b.mbox.gz" => \$uc, MultiStream => 1) or
+		 xbail "gunzip $GunzipError";
 	is($uc, $exp, 'compressed and uncompressed match (b.gz)');
 
-	open $fh, '<', "$ENV{HOME}/b" or xbail "open: $!";
+	open $fh, '<', "$home/b" or xbail "open: $!";
 	$uc = do { local $/; <$fh> };
 	is($uc, $exp, 'uncompressed both match');
 
-	lei_ok [ qw(up -q), "$ENV{HOME}/b", "--mua=touch $ENV{HOME}/c" ],
+	lei_ok [ qw(up -q), "$home/b", "--mua=touch $home/c" ],
 		undef, { run_mode => 0 };
-	ok(-f "$ENV{HOME}/c", '--mua works with single output');
+	ok(-f "$home/c", '--mua works with single output');
 });
 
 done_testing;

  parent reply	other threads:[~2022-09-30  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30  9:21 [PATCH 0/4] fixes noticed while diagnosing t/lei-up.t Eric Wong
2022-09-30  9:21 ` [PATCH 1/4] tests: favor 3 argument `open' with interopolation Eric Wong
2022-09-30  9:21 ` Eric Wong [this message]
2022-09-30  9:21 ` [PATCH 3/4] lei_to_mail: propagate errors to script/lei Eric Wong
2022-09-30  9:21 ` [PATCH 4/4] t/altid_v2: improve test style Eric Wong
2022-09-30 17:20 ` SQLite <3.8.3 was broken on fork (was: fixes noticed while diagnosing t/lei-up.t) Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220930092140.3894047-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).