From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.0.0.0/16 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2ABF91F506 for ; Wed, 21 Sep 2022 17:46:20 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ob3ne-0006oN-JQ; Wed, 21 Sep 2022 19:46:18 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ob3nf-0026IF-7d; Wed, 21 Sep 2022 19:46:17 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ob3nc-002Vc0-Op; Wed, 21 Sep 2022 19:46:16 +0200 Date: Wed, 21 Sep 2022 19:46:13 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Eric Wong Cc: meta@public-inbox.org Subject: Re: [PATCH] t/pop3d: skip all tests if no certs are found Message-ID: <20220921174613.kek374tw643m3azg@pengutronix.de> References: <20220921154741.siubptwcv4463w5l@pengutronix.de> <20220921170254.M219817@dcvr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2ptcinp2iao6dqth" Content-Disposition: inline In-Reply-To: <20220921170254.M219817@dcvr> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: meta@public-inbox.org List-Id: --2ptcinp2iao6dqth Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Eric, On Wed, Sep 21, 2022 at 05:02:54PM +0000, Eric Wong wrote: > Uwe Kleine-K=F6nig wrote: > > $ prove t/pop3d.t > > t/pop3d.t .. skipped: certs/ missing for t/pop3d.t, run /usr/bin/perl = =2E/create-certs.perl in certs/ >=20 > > t/pop3d.t (Wstat: 0 Tests: 2 Failed: 0) > > Parse errors: Bad plan. You planned 0 tests but ran 2. >=20 > > It looks better after I called the create-certs script, but IMHO it > > should work as is and just skip the two tests as advertised? >=20 > Oops, yes, fix at bottom. >=20 > > After calling the create-certs script I get: > >=20 > > t/pop3d.t .. 1/? Not enough arguments for PublicInbox::Daemon::run at = blib/script/public-inbox-pop3d line 8, near "'pop3://0.0.0.0:110')" > > Execution of blib/script/public-inbox-pop3d aborted due to compilation= errors. >=20 > You need to use `prove -b' to add blib/{lib,arch} to the search > path. Omitting -b means you're using the system-wide installed > version. >=20 > `prove -l' also works for this project for users who don't run > `make' first (uses ./lib instead of blib/...) since this project > has no XS. Ah, that makes sense! =20 > > Then it hangs. I'm not fluent enough in Perl to fix that quickly myself > > and my today's time to look into public-inbox is running out, so I > > thought I let you know. >=20 > No worries, I should be online more the rest of the year :> >=20 > --------8<------- > Subject: [PATCH] t/pop3d: skip all tests if no certs are found >=20 > This test could be written with optional OpenSSL dependencies, but > it's probably not worth it since IO::Socket::SSL seems pretty > common. >=20 > Reported-by: Uwe Kleine-K=F6nig > Link: https://public-inbox.org/meta/20220921154741.siubptwcv4463w5l@pengu= tronix.de/ Works great, thanks, Tested-by: Uwe Kleine-K=F6nig Thanks a lot for your quick and helpful reply, Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --2ptcinp2iao6dqth Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmMrTeIACgkQwfwUeK3K 7An+zQf/UC6xHBai+pyebSwf7T+Ypa5XgzehwbgDqsakmOA82Q3NwDYTeBGzam/o HiaEFNIzqO//LZYKur4NCYwZ5R/j2zhJLQJDUNMDUewRpTuH7bvA76UGtbO9Vgj3 79AsUNbAdIowuT+RpeeUiNlJopETol8eiDBaqZ6YyFUuohMEIwPGtgqSl67A4dej v/s7pAvYvpl/+11oaMpVHBSAkzFcm61JO0RTkAMmicATik3dD1TyApdiFvHBtXSk PiCU8TY4uWp8zOohoKzuGEun11OHbE/d33YKHlW97uYZBAWVsjjP67EW9p76kTXv H09d6roqahbcZNv790JfMUjUgKWcgg== =EIZ9 -----END PGP SIGNATURE----- --2ptcinp2iao6dqth--