user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Eric Wong <e@80x24.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] t/pop3d: skip all tests if no certs are found
Date: Wed, 21 Sep 2022 19:46:13 +0200	[thread overview]
Message-ID: <20220921174613.kek374tw643m3azg@pengutronix.de> (raw)
In-Reply-To: <20220921170254.M219817@dcvr>

[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]

Hello Eric,

On Wed, Sep 21, 2022 at 05:02:54PM +0000, Eric Wong wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > 	$ prove t/pop3d.t
> > 	t/pop3d.t .. skipped: certs/ missing for t/pop3d.t, run /usr/bin/perl ./create-certs.perl in certs/
> 
> > 	t/pop3d.t (Wstat: 0 Tests: 2 Failed: 0)
> > 	  Parse errors: Bad plan.  You planned 0 tests but ran 2.
> 
> > It looks better after I called the create-certs script, but IMHO it
> > should work as is and just skip the two tests as advertised?
> 
> Oops, yes, fix at bottom.
> 
> > After calling the create-certs script I get:
> > 
> > 	t/pop3d.t .. 1/? Not enough arguments for PublicInbox::Daemon::run at blib/script/public-inbox-pop3d line 8, near "'pop3://0.0.0.0:110')"
> > 	Execution of blib/script/public-inbox-pop3d aborted due to compilation errors.
> 
> You need to use `prove -b' to add blib/{lib,arch} to the search
> path.  Omitting -b means you're using the system-wide installed
> version.
> 
> `prove -l' also works for this project for users who don't run
> `make' first (uses ./lib instead of blib/...) since this project
> has no XS.

Ah, that makes sense!
 
> > Then it hangs. I'm not fluent enough in Perl to fix that quickly myself
> > and my today's time to look into public-inbox is running out, so I
> > thought I let you know.
> 
> No worries, I should be online more the rest of the year :>
> 
> --------8<-------
> Subject: [PATCH] t/pop3d: skip all tests if no certs are found
> 
> This test could be written with optional OpenSSL dependencies, but
> it's probably not worth it since IO::Socket::SSL seems pretty
> common.
> 
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Link: https://public-inbox.org/meta/20220921154741.siubptwcv4463w5l@pengutronix.de/

Works great, thanks,

Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks a lot for your quick and helpful reply,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2022-09-21 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 15:47 t/pop3d.t failure on 1.9.0 Uwe Kleine-König
2022-09-21 17:02 ` [PATCH] t/pop3d: skip all tests if no certs are found Eric Wong
2022-09-21 17:46   ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921174613.kek374tw643m3azg@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).