* [PATCH] git_async_cat: don't use Gcf2 for temporary git dirs
@ 2022-09-12 16:04 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-09-12 16:04 UTC (permalink / raw)
To: meta
We don't want to be holding references to temporary directories
longer than necessary, an Gcf is intended to be long-lived.
---
lib/PublicInbox/GitAsyncCat.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index c12c4ec2..b32c2fd3 100644
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -51,7 +51,8 @@ sub ibx_async_cat ($$$$) {
# {topdir} means ExtSearch (likely [extindex "all"]) with potentially
# 100K alternates. git(1) has a proposed patch for 100K alternates:
# <https://lore.kernel.org/git/20210624005806.12079-1-e@80x24.org/>
- if (!defined($ibx->{topdir}) && ($GCF2C //= eval {
+ if (!defined($ibx->{topdir}) && !defined($git->{-tmp}) &&
+ ($GCF2C //= eval {
require PublicInbox::Gcf2Client;
PublicInbox::Gcf2Client::new();
} // 0)) { # 0: do not retry if libgit2 or Inline::C are missing
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-12 16:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 16:04 [PATCH] git_async_cat: don't use Gcf2 for temporary git dirs Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).