From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id F183B1F661 for ; Sat, 10 Sep 2022 08:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1662797936; bh=xHKyLbK0Bye1UylQNH/QHflGYt59jja5klC5dvE7Pyg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=oeRInpfvtmNZ1cH9acGoCYHf+YljL9Sk/BIof3hrY78NKXlYThBQhd0i48TDrkNip fGtq4PyQGOp1qQI8m5zV0hRngVzdtlGao67hOciB3HE78/zBlhBOTB4Qs0BGXSPRJQ TNgwSNDtAooQ4pcAYM9y0n855SI/27QYAiOTLi6g= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 24/38] viewdiff: diff_hunk: shorten conditionals, slightly Date: Sat, 10 Sep 2022 08:17:15 +0000 Message-Id: <20220910081729.2011934-25-e@80x24.org> In-Reply-To: <20220910081729.2011934-1-e@80x24.org> References: <20220910081729.2011934-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: I'm not sure if Devel::Size::total_size can be trusted due to the regexps and crashes[1], but when it works, it's showing around a 900 byte size reduction, too. [1] https://rt.cpan.org/Public/Bug/Display.html?id=96421 --- lib/PublicInbox/ViewDiff.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index b9194ed4..076aa1af 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -51,13 +51,10 @@ sub diff_hunk ($$$) { my ($oid_a, $oid_b, $spfx) = @$dctx{qw(oid_a oid_b spfx)}; if (defined($spfx) && defined($oid_a) && defined($oid_b)) { - my ($n) = ($ca =~ /^-([0-9]+)/); - $n = defined($n) ? "#n$n" : ''; - + my $n = ($ca =~ /^-([0-9]+)/) ? "#n$1" : ''; my $x = qq(@@ {Q}$n">$ca); - ($n) = ($cb =~ /^\+([0-9]+)/); - $n = defined($n) ? "#n$n" : ''; + $n = ($cb =~ /^\+([0-9]+)/) ? "#n$1" : ''; $x .= qq( {Q}$n">$cb @@); } else { "@@ $ca $cb @@";