From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 199231F54E for ; Thu, 1 Sep 2022 08:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1662021776; bh=/XPQ78CEQ0fULYVp9WnehL2i8sjIrCSAczaeKSzCBEk=; h=From:To:Subject:Date:From; b=x5AYl1YvSRU/IDR0uZbYQAGqNtCyYPzbyGWV84uj4hX2bHz9Rh3GwGg97PslbCjrU GOdyRB4Aon4AwZfz81yEc5QIauXQdfetSqzoDU9b7/t9Xnmg8JsLBZOITfF9EMKqD7 YqMZ0CjjzNy5ofhz52kwql4jIK8wHJs+mYUiTRIo= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] www: always show subject for root of thread skeleton Date: Thu, 1 Sep 2022 08:42:55 +0000 Message-Id: <20220901084255.30298-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: For users with short attention spans, the root message of should have the Subject, since is often truncated in most browsers. --- Just a minor aesthetic improvement I noticed while overhauling large parts of View*.pm to reduce memory traffic and use. And this does have a tiny memory reduction, too :P lib/PublicInbox/View.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index f29fff50..2e5228e1 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -777,7 +777,6 @@ sub thread_skel ($$$) { # when multiple Subject: headers are present, so we follow suit: my $subj = $hdr->header('Subject') // ''; $subj = '(no subject)' if $subj eq ''; - $ctx->{prev_subj} = [ split(/ /, subject_normalized($subj)) ]; $ctx->{cur} = $mid; $ctx->{prev_attr} = ''; $ctx->{prev_level} = 0;