From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 36BD51F54E for ; Fri, 12 Aug 2022 09:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1660295688; bh=8CT69tJnjjK99aI5RiiOSIrzQ9bmNe1IWFfMRscPk50=; h=From:To:Subject:Date:From; b=tj5CoKaGIbcio8LRzoHEjUQ1pWD+lBsUnrMW5dfPSlH6jvxr3KI4DvM1TLHtvHS1O ce7Z+Xc/tidbkKxjMcvJ7lTBV8J04TEMPQMHZF1SnwENI9Yiv0vu/2EoyQjzmtrpeV TSwzOdkmp+5T8HbfcKQKvHaYPqCI4cK/Pu1U66Ew= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] pop3: quiet warning for cached active statements Date: Fri, 12 Aug 2022 09:14:48 +0000 Message-Id: <20220812091448.3436447-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Setting the $if_active parameter of ->prepare_cached to `1' seemed to be the best option many years ago, so it's probably the best option going forward when caching prepared statements. Fixes: cab36ebd00ca72f8 ("pop3: remove untouched rows on QUIT/disconnect") --- lib/PublicInbox/POP3.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/POP3.pm b/lib/PublicInbox/POP3.pm index 82df257c..bd7dfc65 100644 --- a/lib/PublicInbox/POP3.pm +++ b/lib/PublicInbox/POP3.pm @@ -303,7 +303,7 @@ sub __cleanup_state { $self->{pop3d}->{-state_dbh}->prepare_cached(<<'')->execute($txn_id); DELETE FROM deletes WHERE txn_id = ? AND uid_dele = -1 - my $sth = $self->{pop3d}->{-state_dbh}->prepare_cached(<<''); + my $sth = $self->{pop3d}->{-state_dbh}->prepare_cached(<<'', undef, 1); SELECT COUNT(*) FROM deletes WHERE user_id = ? $sth->execute($user_id);