From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] solver: avoid deprecation warnings in git 2.36.0+
Date: Sat, 30 Jul 2022 09:38:24 +0000 [thread overview]
Message-ID: <20220730093824.19205-1-e@80x24.org> (raw)
git deprecated core.fsyncObjectFiles in favor of core.fsync
with 2.36.0+, while GIT_TEST_FSYNC was added in 2.35.0. So
use the environment variable since it's been supported slightly
longer than the new configuration knob.
---
lib/PublicInbox/SolverGit.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm
index 62b5a343..d3567aa2 100644
--- a/lib/PublicInbox/SolverGit.pm
+++ b/lib/PublicInbox/SolverGit.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2019-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# "Solve" blobs which don't exist in git code repositories by
@@ -301,7 +301,6 @@ sub do_git_init ($) {
repositoryFormatVersion = $v
filemode = true
bare = false
- fsyncObjectfiles = false
logAllRefUpdates = false
EOF
print $fh <<EOM if defined($$fmt);
@@ -325,6 +324,7 @@ EOM
$self->{git_env} = {
GIT_DIR => $git_dir,
GIT_INDEX_FILE => "$git_dir/index",
+ GIT_TEST_FSYNC => 0, # undocumented git env
};
prepare_index($self);
}
reply other threads:[~2022-07-30 9:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220730093824.19205-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).