From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 07/11] nntp: listgroup_range_i: remove useless `map' op
Date: Sat, 23 Jul 2022 04:41:51 +0000 [thread overview]
Message-ID: <20220723044155.3733949-8-e@80x24.org> (raw)
In-Reply-To: <20220723044155.3733949-1-e@80x24.org>
No need to iterate through the array twice; and this even seems
a hair faster than what I got with commit 726d6e71aee5d974
(nntp: small speed up for multi-line responses, 2020-12-04)
---
lib/PublicInbox/NNTP.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 43219b36..ab6eb525 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -189,7 +189,7 @@ sub listgroup_range_i {
my ($self, $beg, $end) = @_;
my $r = $self->{ibx}->mm(1)->msg_range($beg, $end, 'num');
scalar(@$r) or return;
- $self->msg_more(join('', map { "$_->[0]\r\n" } @$r));
+ $self->msg_more(join("\r\n", @$r, ''));
1;
}
next prev parent reply other threads:[~2022-07-23 4:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 4:41 [PATCH 00/11] IMAP, NNTP, POP3 golfing Eric Wong
2022-07-23 4:41 ` [PATCH 01/11] nntp: pass regexp to split() callers Eric Wong
2022-07-23 4:41 ` [PATCH 02/11] nntp: start adding CRLF to responses natively Eric Wong
2022-07-23 4:41 ` [PATCH 03/11] nntp: remove more() wrapper Eric Wong
2022-07-23 4:41 ` [PATCH 04/11] ds: support greeting protocols Eric Wong
2022-07-23 4:41 ` [PATCH 05/11] ds: move no-op ->zflush to common base class Eric Wong
2022-07-23 4:41 ` [PATCH 06/11] ds: move requeue_once Eric Wong
2022-07-23 4:41 ` Eric Wong [this message]
2022-07-23 4:41 ` [PATCH 08/11] nntp: inline CRLF in all response lines Eric Wong
2022-07-23 4:41 ` [PATCH 09/11] ds: share long_step between NNTP and IMAP Eric Wong
2022-07-23 4:41 ` [PATCH 10/11] nntp: resolve inboxes immediately on group listings Eric Wong
2022-07-23 4:41 ` [PATCH 11/11] imap+nntp: share COMPRESS implementation Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220723044155.3733949-8-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).