From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id BC12E1F61C for ; Sat, 23 Jul 2022 04:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1658551316; bh=wgeLE0utQ9WF+HsBrKn8CwI5cCWibv3qVqz1Ntvv9vs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=irA8ASN6zLltc4RTi3R09wULtsjVlb857sT9oo69swFXxFiJPrfE4a9GXo+irtvGZ msPAFTJwFvrDNDrai7/o39iDMv+vbyYIHDFinWaK8ngIDXkNJtzjuEYPvyvrFDpHMZ aJsgpPwvwwer6V3Q4nWV+5jp5gR1JTSpeuDdy6TA= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 05/11] ds: move no-op ->zflush to common base class Date: Sat, 23 Jul 2022 04:41:49 +0000 Message-Id: <20220723044155.3733949-6-e@80x24.org> In-Reply-To: <20220723044155.3733949-1-e@80x24.org> References: <20220723044155.3733949-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: More deduplication, and POP3 never needed it. --- lib/PublicInbox/DS.pm | 2 ++ lib/PublicInbox/IMAP.pm | 2 -- lib/PublicInbox/NNTP.pm | 2 -- lib/PublicInbox/POP3.pm | 2 -- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index 79f7046f..daef9d89 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -648,6 +648,8 @@ sub shutdn ($) { } } +sub zflush {} # overridden by NNTPdeflate and IMAPdeflate + sub dwaitpid ($;$$) { my ($pid, $cb, $arg) = @_; if ($in_loop) { diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm index 89a278c1..f4b08eee 100644 --- a/lib/PublicInbox/IMAP.pm +++ b/lib/PublicInbox/IMAP.pm @@ -1271,8 +1271,6 @@ sub event_step { sub compressed { undef } -sub zflush {} # overridden by IMAPdeflate - # RFC 4978 sub cmd_compress ($$$) { my ($self, $tag, $alg) = @_; diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm index 533a0c59..f0ee11cb 100644 --- a/lib/PublicInbox/NNTP.pm +++ b/lib/PublicInbox/NNTP.pm @@ -968,8 +968,6 @@ sub cmd_compress ($$) { undef } -sub zflush {} # overridden by NNTPdeflate - sub cmd_xpath ($$) { my ($self, $mid) = @_; return r501 unless $mid =~ $ONE_MSGID; diff --git a/lib/PublicInbox/POP3.pm b/lib/PublicInbox/POP3.pm index c368615d..fcea4bb9 100644 --- a/lib/PublicInbox/POP3.pm +++ b/lib/PublicInbox/POP3.pm @@ -55,8 +55,6 @@ sub out ($$;@) { printf { $self->{pop3d}->{out} } $fmt."\n", @args; } -sub zflush {} # noop - sub requeue_once ($) { my ($self) = @_; # COMPRESS users all share the same DEFLATE context.