user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] gcf2: avoid excessive checks for unlinked files
Date: Wed, 20 Jul 2022 18:01:28 +0000	[thread overview]
Message-ID: <20220720180128.25836-1-e@80x24.org> (raw)

We were misusing the timer and not expiring it before checking
for unlinked files.  Now, we check for unlinked files every 60s,
instead.
---
 lib/PublicInbox/Gcf2.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Gcf2.pm b/lib/PublicInbox/Gcf2.pm
index f546208f..41ee0715 100644
--- a/lib/PublicInbox/Gcf2.pm
+++ b/lib/PublicInbox/Gcf2.pm
@@ -138,10 +138,12 @@ sub loop (;$) {
 		} else { # check expiry to deal with deleted pack files
 			my $now = clock_gettime(CLOCK_MONOTONIC);
 			$check_at //= $now + $exp;
-			if ($now > $check_at && have_unlinked_files()) {
+			if ($now > $check_at) {
 				undef $check_at;
-				$gcf2 = new();
-				%seen = ();
+				if (have_unlinked_files()) {
+					$gcf2 = new();
+					%seen = ();
+				}
 			}
 		}
 	}

                 reply	other threads:[~2022-07-20 18:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720180128.25836-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).