From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2F04A1F61A; Wed, 20 Jul 2022 09:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1658309054; bh=3yIs+dshuXn9jDOkoJx1wpa4FY/AH/DBPT/fwdMiMVw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=pWbo4d4HTeFY7Iw3RLSC9wnk0gVxnZCrltH3ALdOLUTGusr4g2cvbzUduceUbNtab 9V4Honuwz4zjaLIBcO0UXOWcavjGAxofUXKBaMSESdfee0zPE0oLZXtB5t0mYe6bif vjSCuTFwg4nTzQVcQqw4sNTQZytBVYUmZkPRZhQY= From: Eric Wong To: meta@public-inbox.org Subject: [PATCH v2 4/5] netd: setup TLS bits for well-known STARTTLS ports Date: Wed, 20 Jul 2022 09:24:12 +0000 Message-Id: <20220720092413.3309948-5-e@80x24.org> In-Reply-To: <20220720092413.3309948-1-e@80x24.org> References: <20220720092413.3309948-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Unfortunately, I can't think of an easy way to test this in our test suite since binding these ports are privileged and are often in use, anyways. --- lib/PublicInbox/Daemon.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm index fbce9154..bceae6e5 100644 --- a/lib/PublicInbox/Daemon.pm +++ b/lib/PublicInbox/Daemon.pm @@ -208,7 +208,7 @@ EOF $tls_opt{"$scheme://$sockname"} ||= accept_tls_opt(''); } elsif (($scheme = $KNOWN_STARTTLS{$1})) { $xnetd->{$sockname} = load_mod($scheme); - next if $tls_opt{"$scheme://$sockname"}; + $tls_opt{"$scheme://$sockname"} ||= accept_tls_opt(''); $tls_opt{''} ||= accept_tls_opt(''); } }