From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] eliminate some unused subs
Date: Wed, 24 Nov 2021 15:45:39 +0000 [thread overview]
Message-ID: <20211124154539.350522-1-e@80x24.org> (raw)
->newsgroup_matches was never used, and ->shard_over_check
was dropped in 89193578d21f (extindex: --gc checkpoints, 2021-10-06).
---
lib/PublicInbox/MiscSearch.pm | 35 -------------------------------
lib/PublicInbox/SearchIdxShard.pm | 10 ---------
2 files changed, 45 deletions(-)
diff --git a/lib/PublicInbox/MiscSearch.pm b/lib/PublicInbox/MiscSearch.pm
index 6b575b0da083..c6d2a062a668 100644
--- a/lib/PublicInbox/MiscSearch.pm
+++ b/lib/PublicInbox/MiscSearch.pm
@@ -81,41 +81,6 @@ sub mset {
retry_reopen($self, \&misc_enquire_once, $qr, $opt);
}
-sub ibx_matches_once { # retry_reopen callback
- my ($self, $qr, $by_newsgroup) = @_;
- # double in case no newsgroups are configured:
- my $limit = scalar(keys %$by_newsgroup) * 2;
- my $opt = { limit => $limit, offset => 0, relevance => -1 };
- my $ret = {}; # newsgroup => $ibx of matches
- while (1) {
- my $mset = misc_enquire_once($self, $qr, $opt);
- for my $mi ($mset->items) {
- my ($eidx_key) = xap_terms('Q', $mi->get_document);
- if (defined($eidx_key)) {
- if (my $ibx = $by_newsgroup->{$eidx_key}) {
- $ret->{$eidx_key} = $ibx;
- }
- } else {
- warn <<EOF;
-W: docid=${\$mi->get_docid} has no `Q' (eidx_key) term
-EOF
- }
- }
- my $nr = $mset->size;
- return $ret if $nr < $limit;
- $opt->{offset} += $nr;
- }
-}
-
-# returns a newsgroup => PublicInbox::Inbox mapping
-sub newsgroup_matches {
- my ($self, $qs, $pi_cfg) = @_;
- my $qp = $self->{qp} //= mi_qp_new($self);
- $qs .= ' type:inbox';
- my $qr = $qp->parse_query($qs, $PublicInbox::Search::QP_FLAGS);
- retry_reopen($self, \&ibx_matches_once, $qr, $pi_cfg->{-by_newsgroup});
-}
-
sub ibx_data_once {
my ($self, $ibx) = @_;
my $xdb = $self->{xdb};
diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm
index 8635f5858a8a..000abd9413b5 100644
--- a/lib/PublicInbox/SearchIdxShard.pm
+++ b/lib/PublicInbox/SearchIdxShard.pm
@@ -75,14 +75,4 @@ sub shard_close {
$self->ipc_worker_stop;
}
-sub shard_over_check {
- my ($self, $over) = @_;
- if ($self->{-ipc_req} && $over->{dbh}) {
- # can't send DB handles over IPC, and use read-only to avoid
- # create_tables lock conflict:
- $over = PublicInbox::Over->new($over->{dbh}->sqlite_db_filename)
- }
- $self->ipc_do('over_check', $over);
-}
-
1;
reply other threads:[~2021-11-24 15:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124154539.350522-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).