From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 4BEA21F9FC for ; Tue, 2 Nov 2021 18:14:46 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/3] lei mail-diff: do not default to 'eml' Date: Tue, 2 Nov 2021 18:14:43 +0000 Message-Id: <20211102181445.1897-2-e@80x24.org> In-Reply-To: <20211102181445.1897-1-e@80x24.org> References: <20211102181445.1897-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: In retrospect, this doesn't make sense, since it needs at least two messages to diff. So go about "normal" input rules and require users to specify the format. --- lib/PublicInbox/LeiMailDiff.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/LeiMailDiff.pm b/lib/PublicInbox/LeiMailDiff.pm index b21a0c36..48ba74cf 100644 --- a/lib/PublicInbox/LeiMailDiff.pm +++ b/lib/PublicInbox/LeiMailDiff.pm @@ -76,7 +76,6 @@ sub input_eml_cb { # used by PublicInbox::LeiInput::input_fh sub lei_mail_diff { my ($lei, @argv) = @_; - $lei->{opt}->{'in-format'} //= 'eml' if !grep(/\A[a-z0-9]+:/i, @argv); my $self = bless {}, __PACKAGE__; $self->prepare_inputs($lei, \@argv) or return; my $isatty = -t $lei->{1};