From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 9/9] input_pipe: account for undefined {sock}
Date: Tue, 26 Oct 2021 10:35:57 +0000 [thread overview]
Message-ID: <20211026103557.2738-10-e@80x24.org> (raw)
In-Reply-To: <20211026103557.2738-1-e@80x24.org>
It's possible for ->event_step to fire twice due to ->requeue
with EPOLLET (but not EPOLLONESHOT). So account for that and
avoid causing event loop errors as a result.
---
lib/PublicInbox/InputPipe.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/InputPipe.pm b/lib/PublicInbox/InputPipe.pm
index 00813a0701b1..e1e26e20b9d2 100644
--- a/lib/PublicInbox/InputPipe.pm
+++ b/lib/PublicInbox/InputPipe.pm
@@ -18,7 +18,7 @@ sub consume {
sub event_step {
my ($self) = @_;
- my $r = sysread($self->{sock}, my $rbuf, 65536);
+ my $r = sysread($self->{sock} // return, my $rbuf, 65536);
if ($r) {
$self->{cb}->(@{$self->{args} // []}, $rbuf);
return $self->requeue; # may be regular file or pipe
prev parent reply other threads:[~2021-10-26 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 10:35 [PATCH 0/9] lei p2q: more capable than originally thought Eric Wong
2021-10-26 10:35 ` [PATCH 1/9] doc: tuning: additional notes for many inboxes Eric Wong
2021-10-26 10:35 ` [PATCH 2/9] doc: lei-store-format: mail sync section, update IPC Eric Wong
2021-10-26 10:35 ` [PATCH 3/9] eml: keep body if no headers are found Eric Wong
2021-10-26 10:35 ` [PATCH 4/9] lei q: enable expensive Xapian flags Eric Wong
2021-10-26 10:35 ` [PATCH 5/9] lei inspect: fix atfork hook Eric Wong
2021-10-26 10:35 ` [PATCH 6/9] lei: add net getopt spec to various commands Eric Wong
2021-10-26 10:35 ` [PATCH 7/9] lei p2q: use LeiInput for multi-patch series Eric Wong
2021-10-26 10:35 ` [PATCH 8/9] lei rm|tag: drop redundant mbox+net callbacks Eric Wong
2021-10-26 10:35 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026103557.2738-10-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).