user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] www: mirror: fix rendering of NNTP URLs
@ 2021-10-26  0:48 Kyle Meyer
  2021-10-26  3:30 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle Meyer @ 2021-10-26  0:48 UTC (permalink / raw)
  To: meta

As of commit 738c4a65, the code for reporting NNTP information in
_/text/mirror/ incorrectly uses ->imap_url rather than ->nntp_url.

Fixes: 738c4a65719e6278 ("www: various help text updates")
---
 lib/PublicInbox/WwwText.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/WwwText.pm b/lib/PublicInbox/WwwText.pm
index 211ee8c9..2b4e69fe 100644
--- a/lib/PublicInbox/WwwText.pm
+++ b/lib/PublicInbox/WwwText.pm
@@ -284,7 +284,7 @@ sub _add_imap_nntp_urls ($$) {
   # each subfolder (starting with `0') holds 50K messages at most
 EOM
 	}
-	$urls = $ctx->{ibx}->imap_url($ctx);
+	$urls = $ctx->{ibx}->nntp_url($ctx);
 	if (@$urls) {
 		$$txt .= "\n";
 		$$txt .= @$urls == 1 ? 'Newsgroup' : 'Newsgroups are';

base-commit: 9f3fb207c9daa13648f6d0f960e6fef922b55eab
-- 
2.33.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] www: mirror: fix rendering of NNTP URLs
  2021-10-26  0:48 [PATCH] www: mirror: fix rendering of NNTP URLs Kyle Meyer
@ 2021-10-26  3:30 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2021-10-26  3:30 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: meta

Thanks, pushed as 00db45c43436dde2 (and also the p2q commit
message fix).

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-26  3:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26  0:48 [PATCH] www: mirror: fix rendering of NNTP URLs Kyle Meyer
2021-10-26  3:30 ` Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).