user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: meta@public-inbox.org
Subject: [PATCH] www: mirror: fix rendering of NNTP URLs
Date: Mon, 25 Oct 2021 20:48:10 -0400	[thread overview]
Message-ID: <20211026004810.313713-1-kyle@kyleam.com> (raw)

As of commit 738c4a65, the code for reporting NNTP information in
_/text/mirror/ incorrectly uses ->imap_url rather than ->nntp_url.

Fixes: 738c4a65719e6278 ("www: various help text updates")
---
 lib/PublicInbox/WwwText.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/WwwText.pm b/lib/PublicInbox/WwwText.pm
index 211ee8c9..2b4e69fe 100644
--- a/lib/PublicInbox/WwwText.pm
+++ b/lib/PublicInbox/WwwText.pm
@@ -284,7 +284,7 @@ sub _add_imap_nntp_urls ($$) {
   # each subfolder (starting with `0') holds 50K messages at most
 EOM
 	}
-	$urls = $ctx->{ibx}->imap_url($ctx);
+	$urls = $ctx->{ibx}->nntp_url($ctx);
 	if (@$urls) {
 		$$txt .= "\n";
 		$$txt .= @$urls == 1 ? 'Newsgroup' : 'Newsgroups are';

base-commit: 9f3fb207c9daa13648f6d0f960e6fef922b55eab
-- 
2.33.1


             reply	other threads:[~2021-10-26  0:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  0:48 Kyle Meyer [this message]
2021-10-26  3:30 ` [PATCH] www: mirror: fix rendering of NNTP URLs Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026004810.313713-1-kyle@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).