From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D445A1F670 for ; Sun, 24 Oct 2021 01:45:22 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] viewvcs: die on tmpfile() errors Date: Sun, 24 Oct 2021 01:45:22 +0000 Message-Id: <20211024014522.29173-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Just let Plack::Util::run_app catch the error and generate a 500 response for it. --- lib/PublicInbox/ViewVCS.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index 021b70cf..3cbc363b 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -194,7 +194,7 @@ sub show ($$;$) { $hints->{$to} = $v if $v ne ''; } - $ctx->{'log'} = tmpfile("solve.$oid_b"); + $ctx->{'log'} = tmpfile("solve.$oid_b") // die "tmpfile: $!"; $ctx->{fn} = $fn; my $solver = PublicInbox::SolverGit->new($ctx->{ibx}, \&solve_result, $ctx);