user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] viewvcs: die on tmpfile() errors
@ 2021-10-24  1:45 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-10-24  1:45 UTC (permalink / raw)
  To: meta

Just let Plack::Util::run_app catch the error and generate
a 500 response for it.
---
 lib/PublicInbox/ViewVCS.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 021b70cf..3cbc363b 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -194,7 +194,7 @@ sub show ($$;$) {
 		$hints->{$to} = $v if $v ne '';
 	}
 
-	$ctx->{'log'} = tmpfile("solve.$oid_b");
+	$ctx->{'log'} = tmpfile("solve.$oid_b") // die "tmpfile: $!";
 	$ctx->{fn} = $fn;
 	my $solver = PublicInbox::SolverGit->new($ctx->{ibx},
 						\&solve_result, $ctx);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-24  1:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-24  1:45 [PATCH] viewvcs: die on tmpfile() errors Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).