user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH] searchidx: v1: raise on msgmap init failure
Date: Sat, 23 Oct 2021 19:08:41 +0000	[thread overview]
Message-ID: <> (raw)

Indexing any inboxes requires SQLite and msgmap, so don't hide
exceptions if it fails.
 lib/PublicInbox/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 585f28f5..b886ce78 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -451,7 +451,7 @@ sub add_xapian ($$$$) {
 sub _msgmap_init ($) {
 	my ($self) = @_;
 	die "BUG: _msgmap_init is only for v1\n" if $self->{ibx}->version != 1;
-	$self->{mm} //= eval {
+	$self->{mm} //= do {
 		require PublicInbox::Msgmap;
 		PublicInbox::Msgmap->new_file($self->{ibx}, 1);

                 reply	other threads:[~2021-10-23 19:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).