From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 2/3] lei add-external --mirror: respect client umask Date: Thu, 14 Oct 2021 04:32:54 +0000 [thread overview] Message-ID: <20211014043255.19545-3-e@80x24.org> (raw) In-Reply-To: <20211014043255.19545-1-e@80x24.org> While lei is intended for non-public mail and runs umask(077) by default, externals are one area which can safely defer to the user's umask. Instead of sending it unconditionally with every command, only have lei-daemon request it when necessary. --- lib/PublicInbox/LEI.pm | 11 +++++++++++ lib/PublicInbox/LeiMirror.pm | 2 ++ script/lei | 2 ++ 3 files changed, 15 insertions(+) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index bd8a6bef632b..635cd0c5508a 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -1518,4 +1518,15 @@ sub cfg_dump ($$) { undef; } +sub request_umask { + my ($lei) = @_; + my $s = $lei->{sock} // return; + send($s, 'umask', MSG_EOR) // die "send: $!"; + vec(my $rvec = '', fileno($s), 1) = 1; + select($rvec, undef, undef, 2) or die 'timeout waiting for umask'; + recv($s, my $v, 5, 0) // die "recv: $!"; + (my $u, $lei->{client_umask}) = unpack('AV', $v); + $u eq 'u' or warn "E: recv $v has no umask"; +} + 1; diff --git a/lib/PublicInbox/LeiMirror.pm b/lib/PublicInbox/LeiMirror.pm index 1369c00c57fd..fb73d8631670 100644 --- a/lib/PublicInbox/LeiMirror.pm +++ b/lib/PublicInbox/LeiMirror.pm @@ -424,6 +424,7 @@ sub start_clone_url { sub do_mirror { # via wq_io_do my ($self) = @_; my $lei = $self->{lei}; + umask($lei->{client_umask}) if defined $lei->{client_umask}; eval { my $iv = $lei->{opt}->{'inbox-version'}; if (defined $iv) { @@ -448,6 +449,7 @@ sub start { require PublicInbox::Inbox; require PublicInbox::Admin; require PublicInbox::InboxWritable; + $lei->request_umask; my ($op_c, $ops) = $lei->workers_start($self, 1); $lei->{wq1} = $self; $self->wq_io_do('do_mirror', []); diff --git a/script/lei b/script/lei index bc43779821e7..8f6e8aacb86b 100755 --- a/script/lei +++ b/script/lei @@ -122,6 +122,8 @@ while (1) { $exec_cmd->(\@fds, split(/\0/, $1)); } elsif ($buf eq '-WINCH') { kill($buf, @parent); # for MUA + } elsif ($buf eq 'umask') { + send($sock, 'u'.pack('V', umask), MSG_EOR) or die "send: $!" } elsif ($buf =~ /\Ax_it ([0-9]+)\z/) { $x_it_code ||= $1 + 0; last;
next prev parent reply other threads:[~2021-10-14 4:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-14 4:32 [PATCH 0/3] clone+fetch stuff Eric Wong 2021-10-14 4:32 ` [PATCH 1/3] clone+fetch: respect umask for all downloaded files Eric Wong 2021-10-14 4:32 ` Eric Wong [this message] 2021-10-14 4:32 ` [PATCH 3/3] lei: give workers their own process group Eric Wong 2021-10-14 13:16 ` [PATCH 0/7] lei: more process handling fixes Eric Wong 2021-10-14 13:16 ` [PATCH 1/7] lei: use send() perlop for signals Eric Wong 2021-10-14 13:16 ` [PATCH 2/7] git: async_err shows retried requests properly Eric Wong 2021-10-14 13:16 ` [PATCH 3/7] git: ->fail invokes current callback Eric Wong 2021-10-14 13:16 ` [PATCH 4/7] git: cat-file --batch are their own pgrp Eric Wong 2021-10-14 13:16 ` [PATCH 5/7] lei: TSTP affects all curl and related subprocesses Eric Wong 2021-10-14 13:16 ` [PATCH 6/7] lei up: actually rely on DESTROY for --alllll Eric Wong 2021-10-14 13:16 ` [PATCH 7/7] lei up --all: send signals to workers, receive errors Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211014043255.19545-3-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 2/3] lei add-external --mirror: respect client umask' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).