From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/5] extindex: flush pending reindex before unref
Date: Tue, 12 Oct 2021 22:44:56 +0000 [thread overview]
Message-ID: <20211012224500.2882-2-e@80x24.org> (raw)
In-Reply-To: <20211012224500.2882-1-e@80x24.org>
This prevents unnecessary message renumbering and I/O.
Without this change, there is a small window for long-running
WWW streaming requests to miss a message that was unref-ed
before reindexing. If we expose an "All Mail" mailbox via
IMAP/JMAP, this will save client traffic.
---
lib/PublicInbox/ExtSearchIdx.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index c2ab0447e176..40489eab4c66 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -193,6 +193,7 @@ sub do_xpost ($$) {
$idx->ipc_do('add_eidx_info', $docid, $eidx_key, $eml);
apply_boost($req, $smsg) if $req->{boost_in_use};
} else { # 'd' no {xnum}
+ $self->git->async_wait_all;
$oid = pack('H*', $oid);
_unref_doc($req, $docid, $xibx, undef, $oid, $eml);
}
@@ -261,6 +262,7 @@ sub _blob_missing ($$) { # called when a known $smsg->{blob} is gone
# xnum and ibx are unknown, we only call this when an entry from
# /ei*/over.sqlite3 is bad, not on entries from xap*/over.sqlite3
my $oidbin = pack('H*', $smsg->{blob});
+ $req->{self}->git->async_wait_all;
_unref_doc($req, $smsg, undef, undef, $oidbin);
}
@@ -552,6 +554,7 @@ sub _reindex_finalize ($$$) {
}
return if $nr == 1; # likely, all good
+ $self->git->async_wait_all;
warn "W: #$docid split into $nr due to deduplication change\n";
my @todo;
for my $ary (values %$by_chash) {
@@ -896,6 +899,7 @@ ibx_id = ? AND xnum >= ? AND xnum <= ?
}
return if $sync->{quit};
next unless scalar keys %x3m;
+ $self->git->async_wait_all; # wait for reindex_unseen
# eliminate stale/mismatched entries
my %mismatch = map { $_->{num} => $_->{blob} } @$msgs;
next prev parent reply other threads:[~2021-10-12 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 22:44 [PATCH 0/5] fix extindex reindex harder Eric Wong
2021-10-12 22:44 ` Eric Wong [this message]
2021-10-12 22:44 ` [PATCH 2/5] lei/store: use remove_doc to save some LoC Eric Wong
2021-10-12 22:44 ` [PATCH 3/5] index: optimize after all SQLite DB commits Eric Wong
2021-10-12 22:44 ` [PATCH 4/5] doc: relnotes: note some recent improvements Eric Wong
2021-10-12 22:45 ` [PATCH 5/5] lei up --all: show output for warnings Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012224500.2882-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).