From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 3/6] extindex: rename var: active => active_shards Date: Mon, 11 Oct 2021 08:06:17 +0000 [thread overview] Message-ID: <20211011080620.27478-4-e@80x24.org> (raw) In-Reply-To: <20211011080620.27478-1-e@80x24.org> We also have the idea of active inboxes, too, so "active shards" ought to make the purpose of the data structure more obvious. --- lib/PublicInbox/ExtSearchIdx.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 8da98ba44a9a..64cd8641585d 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -434,7 +434,7 @@ DELETE FROM over WHERE num > 0 AND num NOT IN (SELECT docid FROM xref3) SELECT MIN(num) FROM over WHERE num > 0 EOM $cur // return; # empty - my ($r, $n, %active); + my ($r, $n, %active_shards); $nr = 0; while (1) { $r = $self->{oidx}->dbh->selectcol_arrayref(<<"", undef, $cur); @@ -445,15 +445,15 @@ SELECT num FROM over WHERE num >= ? ORDER BY num ASC LIMIT 10000 for my $i ($cur..($n - 1)) { my $idx = idx_shard($self, $i); $idx->ipc_do('xdb_remove_quiet', $i); - $active{$idx} = $idx; + $active_shards{$idx} = $idx; } $cur = $n + 1; } if (checkpoint_due($sync)) { - for my $idx (values %active) { + for my $idx (values %active_shards) { $nr += $idx->ipc_do('nr_quiet_rm') } - %active = (); + %active_shards = (); reindex_checkpoint($self, $sync); } }
next prev parent reply other threads:[~2021-10-11 8:06 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-11 8:06 [PATCH 0/6] extindex: --reindex --fast gets faster Eric Wong 2021-10-11 8:06 ` [PATCH 1/6] extindex: speed up --reindex --fast Eric Wong 2021-10-11 8:06 ` [PATCH 2/6] sqlite: PRAGMA optimize on close Eric Wong 2021-10-11 8:06 ` Eric Wong [this message] 2021-10-11 8:06 ` [PATCH 4/6] extindex: share unref logic in more places Eric Wong 2021-10-11 8:06 ` [PATCH 5/6] extindex: more consistent doc removal Eric Wong 2021-10-11 8:06 ` [PATCH 6/6] extindex: avoid invalid blobs after unref Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211011080620.27478-4-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 3/6] extindex: rename var: active => active_shards' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).