user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] xt/perf-msgview: modernize, support TEST_BLOB
Date: Wed,  6 Oct 2021 09:42:18 +0000	[thread overview]
Message-ID: <20211006094218.29251-1-e@80x24.org> (raw)

This helped me quickly reproduce a bug in Encode[1] and
will help me determine performance implications of workarounds
for the aforementioned bug.

[1] https://rt.cpan.org/Public/Bug/Display.html?id=139622
---
 xt/perf-msgview.t | 39 ++++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/xt/perf-msgview.t b/xt/perf-msgview.t
index 599808390b6d..f97c06fb2e65 100644
--- a/xt/perf-msgview.t
+++ b/xt/perf-msgview.t
@@ -1,14 +1,16 @@
-# Copyright (C) 2019-2021 all contributors <meta@public-inbox.org>
+#!perl -w
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
-use warnings;
-use Test::More;
+use v5.10.1;
+use PublicInbox::TestCommon;
 use Benchmark qw(:all);
 use PublicInbox::Inbox;
 use PublicInbox::View;
-use PublicInbox::TestCommon;
+use PublicInbox::Spawn qw(popen_rd);
 
 my $inboxdir = $ENV{GIANT_INBOX_DIR} // $ENV{GIANT_PI_DIR};
+my $blob = $ENV{TEST_BLOB};
 plan skip_all => "GIANT_INBOX_DIR not defined for $0" unless $inboxdir;
 
 my @cat = qw(cat-file --buffer --batch-check --batch-all-objects);
@@ -22,10 +24,13 @@ require_mods qw(Plack::Util);
 use_ok 'Plack::Util';
 my $ibx = PublicInbox::Inbox->new({ inboxdir => $inboxdir, name => 'name' });
 my $git = $ibx->git;
-my $fh = $git->popen(@cat);
-my $vec = '';
-vec($vec, fileno($fh), 1) = 1;
-select($vec, undef, undef, 60) or die "timed out waiting for --batch-check";
+my $fh = $blob ? undef : $git->popen(@cat);
+if ($fh) {
+	my $vec = '';
+	vec($vec, fileno($fh), 1) = 1;
+	select($vec, undef, undef, 60) or
+		die "timed out waiting for --batch-check";
+}
 
 my $ctx = {
 	env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'https' },
@@ -47,11 +52,19 @@ my $cb = sub {
 my $t = timeit(1, sub {
 	$ctx->{obuf} = \$obuf;
 	$ctx->{mhref} = '../';
-	while (<$fh>) {
-		($oid, $type) = split / /;
-		next if $type ne 'blob';
-		++$n;
-		$git->cat_async($oid, $cb);
+	if (defined $blob) {
+		my $nr = $ENV{NR} // 10000;
+		for (1..$nr) {
+			++$n;
+			$git->cat_async($blob, $cb);
+		}
+	} else {
+		while (<$fh>) {
+			($oid, $type) = split / /;
+			next if $type ne 'blob';
+			++$n;
+			$git->cat_async($oid, $cb);
+		}
 	}
 	$git->cat_async_wait;
 });

                 reply	other threads:[~2021-10-06  9:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006094218.29251-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH] xt/perf-msgview: modernize, support TEST_BLOB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).