user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] extsearchidx: favor 20-byte OID comparison
@ 2021-10-04 11:12 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-10-04 11:12 UTC (permalink / raw)
  To: meta

As with most of our internal-only code, favor smaller
comparisons to reduce memory traffic.
---
 lib/PublicInbox/ExtSearchIdx.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index eb7c3d67e072..3a1856c84709 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -120,9 +120,8 @@ sub apply_boost ($$) {
 				||
 		$a->[1] <=> $b->[1] # break ties with {xnum}
 	} @$xr3;
-	my $top_blob = unpack('H*', $xr3->[0]->[2]);
 	my $new_smsg = $req->{new_smsg};
-	return if $top_blob ne $new_smsg->{blob}; # loser
+	return if $xr3->[0]->[2] ne pack('H*', $new_smsg->{blob}); # loser
 
 	# replace the old smsg with the more boosted one
 	$new_smsg->{num} = $smsg->{num};

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-04 11:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 11:12 [PATCH] extsearchidx: favor 20-byte OID comparison Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).