user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] extsearchidx: favor 20-byte OID comparison
Date: Mon,  4 Oct 2021 00:12:34 -1100	[thread overview]
Message-ID: <20211004111234.25584-1-e@80x24.org> (raw)

As with most of our internal-only code, favor smaller
comparisons to reduce memory traffic.
---
 lib/PublicInbox/ExtSearchIdx.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index eb7c3d67e072..3a1856c84709 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -120,9 +120,8 @@ sub apply_boost ($$) {
 				||
 		$a->[1] <=> $b->[1] # break ties with {xnum}
 	} @$xr3;
-	my $top_blob = unpack('H*', $xr3->[0]->[2]);
 	my $new_smsg = $req->{new_smsg};
-	return if $top_blob ne $new_smsg->{blob}; # loser
+	return if $xr3->[0]->[2] ne pack('H*', $new_smsg->{blob}); # loser
 
 	# replace the old smsg with the more boosted one
 	$new_smsg->{num} = $smsg->{num};

                 reply	other threads:[~2021-10-04 11:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004111234.25584-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH] extsearchidx: favor 20-byte OID comparison' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).