user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] hl_mod: don't memoize highlight::codeGenerator objects
Date: Mon,  4 Oct 2021 06:10:21 +0000	[thread overview]
Message-ID: <20211004061021.5825-1-e@80x24.org> (raw)

Making them immortal doesn't seem worth it, since doing immortal
allocations after process startup leads to fragmentation.  While
the allocations made by highlight are small, those small
allocations can break up contiguous regions and prevent
consolidation by the malloc.

Since instantiating code generators doesn't seem too expensive,
just use and delete them ASAP.
---
 lib/PublicInbox/HlMod.pm | 38 +++++++++++++++-----------------------
 t/hl_mod.t               |  3 +--
 2 files changed, 16 insertions(+), 25 deletions(-)

diff --git a/lib/PublicInbox/HlMod.pm b/lib/PublicInbox/HlMod.pm
index 9016db3a..f42ece80 100644
--- a/lib/PublicInbox/HlMod.pm
+++ b/lib/PublicInbox/HlMod.pm
@@ -14,7 +14,7 @@
 # wrapper for SWIG-generated highlight.pm bindings
 package PublicInbox::HlMod;
 use strict;
-use warnings;
+use v5.10.1;
 use highlight; # SWIG-generated stuff
 use PublicInbox::Hval qw(src_escape ascii_html);
 my $hl;
@@ -54,8 +54,7 @@ sub _parse_filetypes ($) {
 	(\%ext2lang, \@shebang);
 }
 
-# We only need one instance, so we don't need to do
-# highlight::CodeGenerator::deleteInstance
+# We only need one instance
 sub new {
 	my ($class) = @_;
 	$hl ||= do {
@@ -95,33 +94,26 @@ sub do_hl {
 sub do_hl_lang {
 	my ($self, $str, $lang) = @_;
 
-	my $dir = $self->{-dir};
 	my $langpath;
-
 	if (defined $lang) {
-		$langpath = $dir->getLangPath("$lang.lang") or return;
-		$lang = undef unless -f $langpath
-	}
-	unless (defined $lang) {
-		$lang = _shebang2lang($self, $str) or return;
-		$langpath = $dir->getLangPath("$lang.lang") or return;
-		return unless -f $langpath
+		$langpath = $self->{-dir}->getLangPath("$lang.lang") or return;
+		undef $lang unless -f $langpath;
 	}
-	my $gen = $self->{$langpath} ||= do {
-		my $g = highlight::CodeGenerator::getInstance($highlight::HTML);
-		$g->setFragmentCode(1); # generate html fragment
+	$lang //= _shebang2lang($self, $str) // return;
+	$langpath = $self->{-dir}->getLangPath("$lang.lang") or return;
+	return unless -f $langpath;
 
-		# whatever theme works
-		my $themepath = $dir->getThemePath('print.theme');
-		$g->initTheme($themepath);
-		$g->loadLanguage($langpath);
-		$g->setEncoding('utf-8');
-		$g;
-	};
+	my $g = highlight::CodeGenerator::getInstance($highlight::HTML);
+	$g->setFragmentCode(1); # generate html fragment
 
+	# whatever theme works
+	$g->initTheme($self->{-dir}->getThemePath('print.theme'));
+	$g->loadLanguage($langpath);
+	$g->setEncoding('utf-8');
 	# we assume $$str is valid UTF-8, but the SWIG binding doesn't
 	# know that, so ensure it's marked as UTF-8 even if it isnt...
-	my $out = $gen->generateString($$str);
+	my $out = $g->generateString($$str);
+	highlight::CodeGenerator::deleteInstance($g);
 	utf8::decode($out);
 	src_escape($out);
 	\$out;
diff --git a/t/hl_mod.t b/t/hl_mod.t
index 96878d51..a88f6c03 100644
--- a/t/hl_mod.t
+++ b/t/hl_mod.t
@@ -3,8 +3,7 @@
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict; use v5.10.1; use PublicInbox::TestCommon; use IO::Handle; # ->autoflush
 use Fcntl qw(:seek);
-eval { require highlight } or
-	plan skip_all => "failed to load highlight.pm for $0";
+require_mods 'highlight';
 use_ok 'PublicInbox::HlMod';
 my $hls = PublicInbox::HlMod->new;
 ok($hls, 'initialized OK');

             reply	other threads:[~2021-10-04  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04  6:10 Eric Wong [this message]
2021-10-04  9:50 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004061021.5825-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH] hl_mod: don'\''t memoize highlight::codeGenerator objects' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).