From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6ADDE1F934 for ; Mon, 27 Sep 2021 19:45:23 +0000 (UTC) Received: by mail-qv1-xf32.google.com with SMTP id w8so11937456qvu.1 for ; Mon, 27 Sep 2021 12:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NrixSt2rNPDfMzdMDnaN+mGkdXEwMKdYK3o03mZNItk=; b=Ju8wZ1PkMnatClwF+/O0fh+gp2XIVEzicn32ke/n+QWAwbWbPWOAnQiKWht9ZuNhLx Wdi5LRAQIQaMO/TM/rlX1417OxrlP9EXOsGeM1TxW+QSM4ct3Dl6opmRsbU6XoFykjdH 5tcs4umABc7izU4+CguMhrSu67cmDzLE5gpYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NrixSt2rNPDfMzdMDnaN+mGkdXEwMKdYK3o03mZNItk=; b=wOQth4GDrdCjVTZC+bSFxPLfEcZtuiCbEv75jKyiYdM9Zu9qwwGNnIRV70qk6yvzsH adZch98RrJGklr1HWAIYQtG8QrYi3qNBR1Bt7MoV+tJBgTPKjrwKG78Cg2TTicR9+n3U Jzv4oELNOAah9QCfQ7DW0W8i/OOThTZBZRD+e7tuNmSaN1Wz07fS6WA0zxWPlTP1+dT6 b6nx2jhOKkwVGwAu6c07A1QEZsG8MpaYCRFJPSlHBpDwn0AS4PkhV6HVpdg3GrpFJt56 hZw519FFAiPfMUyZ8+Gq68p+cR22Fgl5lfrdGlE+fvDp9a/FdAEKL1JLVrbzNKfa4ypd 2wmA== X-Gm-Message-State: AOAM5324qU4mRCTTRJoDofk8YHkEgp9tO8BhvJ9AHYFpvM93Ny+ct6z9 XFLVcRby4vdOP/NEnlUGuQmVGSM4huSN6A== X-Google-Smtp-Source: ABdhPJy5nE5HyiWBx+MXnErv41vNpRDczDu24dA+eDvsQV/q3BIhQ5rfZeMpmkK+bRtryQN63o8Xwg== X-Received: by 2002:a0c:a987:: with SMTP id a7mr1673583qvb.1.1632771922163; Mon, 27 Sep 2021 12:45:22 -0700 (PDT) Received: from meerkat.local (bras-base-mtrlpq5031w-grc-32-216-209-220-181.dsl.bell.ca. [216.209.220.181]) by smtp.gmail.com with ESMTPSA id c139sm13556466qkg.2.2021.09.27.12.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 12:45:21 -0700 (PDT) Date: Mon, 27 Sep 2021 15:45:20 -0400 From: Konstantin Ryabitsev To: Eric Wong Cc: meta@public-inbox.org Subject: Re: -fetch failures [was: latest make test failures on CentOS-7] Message-ID: <20210927194520.a26flphsrp72urb5@meerkat.local> References: <20210927124056.kj5okiefvs4ztk27@meerkat.local> <20210927193346.GA18520@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210927193346.GA18520@dcvr> List-Id: On Mon, Sep 27, 2021 at 07:33:46PM +0000, Eric Wong wrote: > Konstantin Ryabitsev wrote: > > t/v2mirror.t ................. 71/? W: /tmp/pi-v2mirror-39373-Dl1N/m/git/3.git missing remote.origin.url > > fatal: not a git repository: '/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git' > > git --git-dir=/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git fetch -q failed > > Bailout called. Further testing stopped: -fetch failed > > FAILED--Further testing stopped: -fetch failed > > make: *** [test_dynamic] Error 255 > > > > FYI, this is git 2.31.1. > > I'm not seeing this at all with 2.31.1, 2.20, 2.33... > I wonder if there's a permissions problem or some latent GIT_* > var in env... > > Are you testing as root? I think that would be broken, yes. Yes, this is testing as root, largely because automatic deployment makes it hard to do the checkout/make/make test as an unprivileged user. I appreciate that in most other scenarios the final step would be "sudo make install" but when things are installed via configuration management, the process usually runs as root already and su-ing to a user for "make test" is adding more complication to the process. > The partial fetching would need some work to support working as > root. Ah. Just catch this with check if if id=0 and skipping the test as "known not to work for this use-case." -K