From: Konstantin Ryabitsev <email@example.com> To: Eric Wong <firstname.lastname@example.org> Cc: email@example.com Subject: Re: -fetch failures [was: latest make test failures on CentOS-7] Date: Mon, 27 Sep 2021 15:45:20 -0400 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20210927193346.GA18520@dcvr> On Mon, Sep 27, 2021 at 07:33:46PM +0000, Eric Wong wrote: > Konstantin Ryabitsev <email@example.com> wrote: > > t/v2mirror.t ................. 71/? W: /tmp/pi-v2mirror-39373-Dl1N/m/git/3.git missing remote.origin.url > > fatal: not a git repository: '/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git' > > git --git-dir=/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git fetch -q failed > > Bailout called. Further testing stopped: -fetch failed > > FAILED--Further testing stopped: -fetch failed > > make: *** [test_dynamic] Error 255 > > > > FYI, this is git 2.31.1. > > I'm not seeing this at all with 2.31.1, 2.20, 2.33... > I wonder if there's a permissions problem or some latent GIT_* > var in env... > > Are you testing as root? I think that would be broken, yes. Yes, this is testing as root, largely because automatic deployment makes it hard to do the checkout/make/make test as an unprivileged user. I appreciate that in most other scenarios the final step would be "sudo make install" but when things are installed via configuration management, the process usually runs as root already and su-ing to a user for "make test" is adding more complication to the process. > The partial fetching would need some work to support working as > root. Ah. Just catch this with check if if id=0 and skipping the test as "known not to work for this use-case." -K
next prev parent reply other threads:[~2021-09-27 19:45 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-27 12:40 latest make test failures on CentOS-7 Konstantin Ryabitsev 2021-09-27 18:35 ` [PATCH] t/cmd_ipc: allow extra errors and add diagnostics Eric Wong 2021-09-27 18:51 ` Konstantin Ryabitsev 2021-09-27 19:33 ` -fetch failures [was: latest make test failures on CentOS-7] Eric Wong 2021-09-27 19:45 ` Konstantin Ryabitsev [this message] 2021-09-27 21:05 ` [PATCH 0/3] fixes for odd/old/missing dependencies Eric Wong 2021-09-27 21:05 ` [PATCH 1/3] fetch: support running as root Eric Wong 2021-09-27 21:05 ` [PATCH 2/3] t/lei-index: IMAP and NNTP dependencies are optional Eric Wong 2021-09-27 21:05 ` [PATCH 3/3] lei completion: workaround old Perl bug Eric Wong 2021-09-27 21:27 ` [PATCH 0/3] fixes for odd/old/missing dependencies Konstantin Ryabitsev 2021-09-27 21:40 ` Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: -fetch failures [was: latest make test failures on CentOS-7]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).