user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: [PATCH] t/cmd_ipc: allow extra errors and add diagnostics
Date: Mon, 27 Sep 2021 13:35:36 -0500	[thread overview]
Message-ID: <20210927183536.GA2917@dcvr> (raw)
In-Reply-To: <20210927124056.kj5okiefvs4ztk27@meerkat.local>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>     t/cmd_ipc.t .................. 29/?
>     #   Failed test 'got EMSGSIZE'
>     #   at t/cmd_ipc.t line 108.
>     # Looks like you failed 1 test of 42.
>     t/cmd_ipc.t .................. Dubious, test returned 1 (wstat 256, 0x100)
>     Failed 1/42 subtests
>             (less 13 skipped subtests: 28 okay)

I think this is either caused by too much RAM and/or
/proc/sys/net/core/wmem_* being larger-than-expected
(both default to 212992 for me).

This fixes failures when I set both wmem_max and wmem_default
to 2129920 (10x its default value).

-------------8<-----------
Subject: [PATCH] t/cmd_ipc: allow extra errors and add diagnostics

Apparently, sendmsg can fail in less common ways when
network buffers are gigantic.  Add some diagnostics for
future failures, as well.

Link: https://public-inbox.org/meta/20210927124056.kj5okiefvs4ztk27@meerkat.local/
---
 t/cmd_ipc.t | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/t/cmd_ipc.t b/t/cmd_ipc.t
index c5e715a1cd8a..dd90fa2a63e4 100644
--- a/t/cmd_ipc.t
+++ b/t/cmd_ipc.t
@@ -85,7 +85,9 @@ my $do_test = sub { SKIP: {
 			$nsent += $n;
 			fail "sent 0 bytes" if $n == 0;
 		}
-		ok($!{EAGAIN}, "hit EAGAIN on send $desc");
+		ok($!{EAGAIN} || $!{ETOOMANYREFS},
+			"hit EAGAIN || ETOOMANYREFS on send $desc") or
+			diag "send failed with: $!";
 		ok($nsent > 0, 'sent some bytes');
 
 		socketpair($s1, $s2, AF_UNIX, $type, 0) or BAIL_OUT $!;
@@ -105,8 +107,9 @@ my $do_test = sub { SKIP: {
 				diag "sent $nr, retrying with more";
 				$nr += 2 * 1024 * 1024;
 			} else {
-				ok($!{EMSGSIZE}, 'got EMSGSIZE');
-				# diag "$nr bytes hits EMSGSIZE";
+				ok($!{EMSGSIZE} || $!{ENOBUFS},
+					'got EMSGSIZE or ENOBUFS') or
+					diag "$nr bytes fails with: $!";
 				last;
 			}
 		}

  reply	other threads:[~2021-09-27 18:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 12:40 latest make test failures on CentOS-7 Konstantin Ryabitsev
2021-09-27 18:35 ` Eric Wong [this message]
2021-09-27 18:51   ` [PATCH] t/cmd_ipc: allow extra errors and add diagnostics Konstantin Ryabitsev
2021-09-27 19:33 ` -fetch failures [was: latest make test failures on CentOS-7] Eric Wong
2021-09-27 19:45   ` Konstantin Ryabitsev
2021-09-27 21:05     ` [PATCH 0/3] fixes for odd/old/missing dependencies Eric Wong
2021-09-27 21:05       ` [PATCH 1/3] fetch: support running as root Eric Wong
2021-09-27 21:05       ` [PATCH 2/3] t/lei-index: IMAP and NNTP dependencies are optional Eric Wong
2021-09-27 21:05       ` [PATCH 3/3] lei completion: workaround old Perl bug Eric Wong
2021-09-27 21:27       ` [PATCH 0/3] fixes for odd/old/missing dependencies Konstantin Ryabitsev
2021-09-27 21:40         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927183536.GA2917@dcvr \
    --to=e@80x24.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH] t/cmd_ipc: allow extra errors and add diagnostics' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).