user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] net_reader: drop support for IgnoreSizeErrors option
@ 2021-09-26 21:25 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2021-09-26 21:25 UTC (permalink / raw)
  To: meta

Only the ->message_string method of Mail::IMAPClient uses it,
and we have no intention of using ->message_string outside
of tests.
---
 Documentation/lei-config.pod | 6 ------
 lib/PublicInbox/NetReader.pm | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/Documentation/lei-config.pod b/Documentation/lei-config.pod
index c91f36ee..154295ce 100644
--- a/Documentation/lei-config.pod
+++ b/Documentation/lei-config.pod
@@ -84,12 +84,6 @@ Small responses for IMAP flags are fetched at 10000 times this value.
 
 Default: 1
 
-=item imap.ignoreSizeErrors
-
-Ignore size mismatches from broken IMAP server implementations.
-
-Default: false
-
 =item color.SLOT
 
 C<quoted>, C<hdrdefault>, C<status>, C<attachment> color slots
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index eab7320e..2b74af41 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -328,7 +328,7 @@ sub imap_common_init ($;$) {
 		my $sec = uri_section($uri);
 
 		# knobs directly for Mail::IMAPClient->new
-		for my $k (qw(Starttls Debug Compress Ignoresizeerrors)) {
+		for my $k (qw(Starttls Debug Compress)) {
 			my $bool = cfg_bool($cfg, "imap.$k", $$uri) // next;
 			$mic_common->{$sec}->{$k} = $bool;
 		}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-26 21:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-26 21:25 [PATCH] net_reader: drop support for IgnoreSizeErrors option Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).