user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] net_reader: drop support for IgnoreSizeErrors option
Date: Sun, 26 Sep 2021 21:25:47 +0000	[thread overview]
Message-ID: <20210926212547.11034-1-e@80x24.org> (raw)

Only the ->message_string method of Mail::IMAPClient uses it,
and we have no intention of using ->message_string outside
of tests.
---
 Documentation/lei-config.pod | 6 ------
 lib/PublicInbox/NetReader.pm | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/Documentation/lei-config.pod b/Documentation/lei-config.pod
index c91f36ee..154295ce 100644
--- a/Documentation/lei-config.pod
+++ b/Documentation/lei-config.pod
@@ -84,12 +84,6 @@ Small responses for IMAP flags are fetched at 10000 times this value.
 
 Default: 1
 
-=item imap.ignoreSizeErrors
-
-Ignore size mismatches from broken IMAP server implementations.
-
-Default: false
-
 =item color.SLOT
 
 C<quoted>, C<hdrdefault>, C<status>, C<attachment> color slots
diff --git a/lib/PublicInbox/NetReader.pm b/lib/PublicInbox/NetReader.pm
index eab7320e..2b74af41 100644
--- a/lib/PublicInbox/NetReader.pm
+++ b/lib/PublicInbox/NetReader.pm
@@ -328,7 +328,7 @@ sub imap_common_init ($;$) {
 		my $sec = uri_section($uri);
 
 		# knobs directly for Mail::IMAPClient->new
-		for my $k (qw(Starttls Debug Compress Ignoresizeerrors)) {
+		for my $k (qw(Starttls Debug Compress)) {
 			my $bool = cfg_bool($cfg, "imap.$k", $$uri) // next;
 			$mic_common->{$sec}->{$k} = $bool;
 		}

                 reply	other threads:[~2021-09-26 21:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210926212547.11034-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).